Add first unit tests for process_pool_worker #3766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khk-globus
force-pushed
the
add_unit_test_for_ppw
branch
3 times, most recently
from
a517a83 to
eb03e75
Compare
The only change of note is to move the ArgumentParser to a function to enable writing unit tests for it. No user-functional change.
khk-globus
force-pushed
the
add_unit_test_for_ppw
branch
from
eb03e75 to
485eecb
Compare
benclifford
reviewed
Feb 13, 2025
benclifford
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only change of note is to move the
ArgumentParserto a function to enable writing unit tests for it.Changed Behaviour
No user-functional change.
Type of change