Updated Dev Quotes

Signed-off-by: Peter Macdonald <[email protected]>
Parsifal-M · Nov 26, 2023 · 4a8f86b · 4a8f86b
1 parent 81973cf
commit 4a8f86b
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 8 deletions.
diff --git a/packages/app/src/components/catalog/EntityPage.tsx b/packages/app/src/components/catalog/EntityPage.tsx
@@ -122,7 +122,7 @@ const overviewContent = (
     <Grid item md={6} xs={12}>
       <EntityCatalogGraphCard variant="gridItem" height={400} />
     </Grid>
-    <Grid item md={4} xs={12}>
+    <Grid item md={6} xs={12}>
       <DevQuote />
     </Grid>
 

diff --git a/packages/backend/src/plugins/permission.ts b/packages/backend/src/plugins/permission.ts
@@ -16,14 +16,15 @@ export default async function createPlugin(
   env: PluginEnvironment,
 ): Promise<Router> {
   const opaClient = new OpaClient(env.config, env.logger);
-  const genericPolicyEvaluator = policyEvaluator(opaClient, env.config);
+  const genericPolicyEvaluator = policyEvaluator(opaClient);
   class PermissionsHandler implements PermissionPolicy {
     async handle(
       request: PolicyQuery,
       user?: BackstageIdentityResponse,
     ): Promise<PolicyDecision> {
       return await genericPolicyEvaluator(request, user);
     }
+
   }
 
   return await createRouter({

diff --git a/...ts/QuotesCardComponent/DevQuotes.test.tsx → ...onents/QuotesComponent/DevQuotes.test.tsx b/...ts/QuotesCardComponent/DevQuotes.test.tsx → ...onents/QuotesComponent/DevQuotes.test.tsx
diff --git a/...ponents/QuotesCardComponent/DevQuotes.tsx → .../components/QuotesComponent/DevQuotes.tsx b/...ponents/QuotesCardComponent/DevQuotes.tsx → .../components/QuotesComponent/DevQuotes.tsx
@@ -1,14 +1,23 @@
-import { Typography } from '@material-ui/core';
+import { Typography, makeStyles } from '@material-ui/core';
 import React from 'react';
 import { quotes } from '../../quotes';
 
+const useStyles = makeStyles((theme) => ({
+  footer: {
+    width: '100%',
+    textAlign: 'center',
+    padding: theme.spacing(2),
+  },
+}));
+
 export const DevQuote = () => {
+  const classes = useStyles();
   const randomQuote = quotes[Math.floor(Math.random() * quotes.length)];
 
   return (
-    <>
+    <footer className={classes.footer}>
       <Typography variant="h6">{randomQuote.text}</Typography>
       <Typography variant="subtitle2">{randomQuote.author}</Typography>
-    </>
+    </footer>
   );
-};
+};
diff --git a/...c/components/QuotesCardComponent/index.ts → ...e/src/components/QuotesComponent/index.ts b/...c/components/QuotesCardComponent/index.ts → ...e/src/components/QuotesComponent/index.ts
diff --git a/plugins/dev-quotes-homepage/src/index.ts b/plugins/dev-quotes-homepage/src/index.ts
@@ -1 +1 @@
-export * from './components/QuotesCardComponent';
+export * from './components/QuotesComponent';
diff --git a/plugins/dev-quotes-homepage/src/plugin.ts b/plugins/dev-quotes-homepage/src/plugin.ts
@@ -15,7 +15,7 @@ export const DevQuotesHomepage = devQuotesHomepage.provide(
   createRoutableExtension({
     name: 'DevQuotesHomepage',
     component: () =>
-      import('./components/QuotesCardComponent').then(m => m.DevQuote),
+      import('./components/QuotesComponent').then(m => m.DevQuote),
     mountPoint: rootRouteRef,
   }),
 );
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		export * from './components/QuotesCardComponent';
		export * from './components/QuotesComponent';