Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrectly named param in Consumable #322

Merged
merged 1 commit into from
Feb 15, 2025
Merged

Fix incorrectly named param in Consumable #322

merged 1 commit into from
Feb 15, 2025

Conversation

HaHaWTH
Copy link
Contributor

@HaHaWTH HaHaWTH commented Feb 15, 2025 •
edited
Loading

The consumable Builder here is assigning value to consumeSeconds(Mojang mapping), but the parameter passed in is incorrectly named as consumeSounds

image

@HaHaWTH HaHaWTH requested a review from a team as a code owner February 15, 2025 13:37
@CLAassistant
Copy link

CLAassistant commented Feb 15, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Matyrobbrt Matyrobbrt merged commit f388009 into ParchmentMC:versions/1.21.x Feb 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matyrobbrt Matyrobbrt Matyrobbrt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaHaWTH @CLAassistant @Matyrobbrt