Attack chain migration: /obj/machinery #27784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you finishing all your work before the new year? I can't imagine how to review this. |
1080pCat
added
Code Improvement
ParadiseSS13-Bot
added
the
-Status: Awaiting type assignment
Sadly this is the work that needs to be done before I can start next year's projects. In this particular case, I'm not PRing the kitchen rework before this PR, because the kitchen rework introduces a bunch of additional machines I don't want on the old attack chain. As to how to review it: very carefully. |
ParadiseSS13-Bot
added
-Status: Awaiting review
Drsmail
suggested changes
Jan 1, 2025
…star-orion/Paradise into attack-chain-migration/machinery
1 task
warriorstar-orion
changed the title
FunnyMan3595
suggested changes
Jan 20, 2025
Burzah
reviewed
Jan 20, 2025
FunnyMan3595
approved these changes
Jan 20, 2025
ParadiseSS13-Bot
added
-Status: Awaiting merge
Burzah
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR migrates the
/obj/machinerytype tree to the new attack chain.Yes, the PR could have been smaller by not renaming the arguments that were passed in to the legacy methods but 1) not that smaller and 2) it helps me keep track of the code paths that actually interact with the passed in objects.
Why It's Good For The Game
Critical part of attack chain migration.
Testing
The plan is to implement as many of these as possible into game tests without the tests being flaky or taking way too long to run.
Test Plan
/obj/machinery/dna_scannernew/item_interaction(...)/obj/machinery/computer/scan_consolenew/item_interaction(...)/obj/machinery/abductor/console/item_interaction(...)/obj/machinery/abductor/gland_dispenser/item_interaction(...)/obj/machinery/abductor/experiment/item_interaction(...)/obj/machinery/nuclearbomb/item_interaction(...)/obj/machinery/pdapainter/item_interaction(...)/obj/machinery/sleeper/item_interaction(...)/obj/machinery/bodyscanner/item_interaction(...)/obj/machinery/access_button/item_interaction(...)/obj/machinery/autolathe/item_interaction(...)/obj/machinery/camera/item_interaction(...)/obj/machinery/cell_charger/item_interaction(...)/obj/machinery/clonepod/item_interaction(...)/obj/machinery/readybutton/item_interaction(...)/obj/machinery/computer/card/item_interaction(...)/obj/machinery/computer/cloning/item_interaction(...)/obj/machinery/computer/borgupload/item_interaction(...)/obj/machinery/computer/aiupload/item_interaction(...)/obj/machinery/computer/med_data/item_interaction(...)/obj/machinery/computer/prisoner/item_interaction(...)/obj/machinery/computer/secure_data/item_interaction(...)/obj/machinery/cryopod/item_interaction(...)/obj/machinery/defibrillator_mount/item_interaction(...)/obj/machinery/door_control/item_interaction(...)/obj/machinery/door/airlock/item_interaction(...)/obj/machinery/door/airlock/plasma/item_interaction(...)/obj/machinery/door/airlock/highsecurity/red/item_interaction(...)/obj/machinery/door/item_interaction(...)/obj/machinery/door/firedoor/item_interaction(...)/obj/machinery/door/window/item_interaction(...)/obj/machinery/doppler_array/item_interaction(...)/obj/machinery/dye_generator/item_interaction(...)/obj/machinery/firealarm/item_interaction(...)/obj/machinery/floodlight/item_interaction(...)/obj/machinery/computer/guestpass/item_interaction(...)/obj/machinery/iv_drip/item_interaction(...)/obj/machinery/item_interaction(...)/obj/machinery/mass_driver_frame/item_interaction(...)/obj/machinery/economy/merch/item_interaction(...)/obj/machinery/navbeacon/item_interaction(...)/obj/machinery/porta_turret/item_interaction(...)/obj/machinery/porta_turret_construct/item_interaction(...)/obj/machinery/recharger/item_interaction(...)/obj/machinery/requests_console/item_interaction(...)/obj/machinery/shieldgen/item_interaction(...)/obj/machinery/shieldwallgen/item_interaction(...)/obj/machinery/shieldwall/syndicate/item_interaction(...)/obj/machinery/space_heater/item_interaction(...)/obj/machinery/suit_storage_unit/item_interaction(...)/obj/machinery/syndicatebomb/item_interaction(...)/obj/machinery/computer/teleporter/item_interaction(...)/obj/machinery/teleport/station/item_interaction(...)/obj/machinery/transformer/gene_applier/item_interaction(...)/obj/machinery/turretid/item_interaction(...)/obj/machinery/economy/vending/item_interaction(...)/obj/machinery/holosign_switch/item_interaction(...)/obj/machinery/washing_machine/item_interaction(...)/obj/machinery/mecha_part_fabricator/item_interaction(...)/obj/machinery/barsign/item_interaction(...)/obj/machinery/grey_autocloner/item_interaction(...)/obj/machinery/shower/item_interaction(...)/obj/machinery/economy/arcade/item_interaction(...)/obj/machinery/prize_counter/item_interaction(...)/obj/machinery/alarm/item_interaction(...)/obj/machinery/atmospherics/item_interaction(...)/obj/machinery/atmospherics/binary/bump/item_interaction(...)/obj/machinery/atmospherics/binary/volume_pump/item_interaction(...)/obj/machinery/atmospherics/trinary/filter/item_interaction(...)/obj/machinery/atmospherics/trinary/mixer/item_interaction(...)/obj/machinery/atmospherics/unary/cryo_cell/item_interaction(...)/obj/machinery/atmospherics/unary/vent_pump/item_interaction(...)/obj/machinery/atmospherics/portable/item_interaction(...)/obj/machinery/computer/account_database/item_interaction(...)/obj/machinery/economy/atm/item_interaction(...)/obj/machinery/fishtank/item_interaction(...)/obj/machinery/bottler/item_interaction(...)/obj/machinery/cooker/item_interaction(...)/obj/machinery/cooker/deepfryer/item_interaction(...)/obj/machinery/gibber/item_interaction(...)/obj/machinery/icemachine/item_interaction(...)/obj/machinery/kitchen_machine/item_interaction(...)/obj/machinery/monkey_recycler/item_interaction(...)/obj/machinery/processor/item_interaction(...)/obj/machinery/smartfridge/item_interaction(...)/obj/machinery/biogenerator/item_interaction(...)/obj/machinery/compost_bin/item_interaction(...)/obj/machinery/plantgenes/item_interaction(...)/obj/machinery/hydroponics/soil/item_interaction(...)/obj/machinery/hydroponics/constructable/item_interaction(...)/obj/machinery/hydroponics/item_interaction(...)/obj/machinery/seed_extractor/item_interaction(...)/obj/machinery/computer/library/item_interaction(...)/obj/machinery/bookbinder/item_interaction(...)/obj/machinery/mineral/labor_points_checker/item_interaction(...)/obj/machinery/mineral/labor_prisoner_shuttle_console/item_interaction(...)/obj/machinery/anomalous_crystal/item_interaction(...)/obj/machinery/mineral/ore_redemption/item_interaction(...)/obj/machinery/mineral/equipment_vendor/item_interaction(...)/obj/machinery/mineral/equipment_vendor/explorer/item_interaction(...)/obj/machinery/mineral/mint/item_interaction(...)/obj/machinery/photocopier/faxmachine/item_interaction(...)/obj/machinery/photocopier/item_interaction(...)/obj/machinery/ticket_machine/item_interaction(...)/obj/machinery/power/apc/item_interaction(...)/obj/machinery/power/terminal/item_interaction(...)/obj/machinery/power/rad_collector/item_interaction(...)/obj/machinery/field/containment/item_interaction(...)/obj/machinery/power/emitter/item_interaction(...)/obj/machinery/particle_accelerator/item_interaction(...)/obj/machinery/atmospherics/supermatter_crystal/item_interaction(...)/obj/machinery/power/grounding_rod/item_interaction(...)/obj/machinery/power/tesla_coil/item_interaction(...)/obj/machinery/power/port_gen/pacman/item_interaction(...)/obj/machinery/power/treadmill/item_interaction(...)/obj/machinery/power/compressor/item_interaction(...)/obj/machinery/power/turbine/item_interaction(...)/obj/machinery/gravity_generator/main/item_interaction(...)/obj/machinery/light/item_interaction(...)/obj/machinery/light/item_interaction(...)/obj/machinery/light_construct/item_interaction(...)/obj/machinery/power/item_interaction(...)/obj/machinery/power/smes/item_interaction(...)/obj/machinery/chem_dispenser/item_interaction(...)/obj/machinery/chem_heater/item_interaction(...)/obj/machinery/chem_master/item_interaction(...)/obj/machinery/computer/pandemic/item_interaction(...)/obj/machinery/reagentgrinder/item_interaction(...)/obj/machinery/conveyor/item_interaction(...)/obj/machinery/disposal/item_interaction(...)/obj/machinery/computer/rnd_backup/item_interaction(...)/obj/machinery/r_n_d/circuit_imprinter/item_interaction(...)/obj/machinery/r_n_d/protolathe/item_interaction(...)/obj/machinery/computer/rdconsole/item_interaction(...)/obj/machinery/r_n_d/scientific_analyzer/item_interaction(...)/obj/machinery/computer/camera_advanced/xenobio/item_interaction(...)/obj/machinery/computer/id_upgrader/item_interaction(...)/obj/machinery/keycard_auth/item_interaction(...)/obj/machinery/computer/emergency_shuttle/item_interaction(...)/obj/machinery/dna_vault/item_interaction(...)/obj/machinery/computer/telescience/item_interaction(...)Declaration
Changelog
NPFC