Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite userdev setup pipeline #276

Merged
merged 10 commits into from
Dec 27, 2024
Merged

Rewrite userdev setup pipeline #276

merged 10 commits into from
Dec 27, 2024

Conversation

jpenilla
Copy link
Member

Uses a graph for ordering steps instead of manual ordering, improved input/output hashing and up-to-date checking.

Except for the final outputs which are keyed to the dev bundle, steps are independent of the dev bundle and can be reused between bundles that have the same inputs for the step. For example when using a Paper and Folia 1.21.4 dev bundle in two projects, decompile will only run once as only the final apply dev bundle patches step differs.

Final outputs are copied into a project local location to avoid projects sharing a bundle from having a task with a shared output location.

Uses a graph for ordering steps instead of manual ordering, improved input/output hashing and up-to-date checking.

Except for the final outputs which are keyed to the dev bundle, steps are independent of the dev bundle and can be reused between bundles that have the same inputs for the step. For example when using a Paper and Folia 1.21.4 dev bundle in two projects, decompile will only run once as only the final apply dev bundle patches step differs.

Final outputs are copied into a project local location to avoid projects sharing a bundle from having a task with a shared output location.
@jpenilla jpenilla linked an issue Dec 26, 2024 that may be closed by this pull request
Cleaning caches and building in the same gradle invocation now works properly
…cution time) instead of simply skipping some configuration

Cleaning the cache and running setup in the same build is now sometimes safe, but not always safe. Whereas before it was never safe. We will continue to disallow it generally.
Copy link
Member

@MiniDigger MiniDigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the new structure and tested on windows

@jpenilla jpenilla merged commit 21b1e82 into main Dec 27, 2024
3 checks passed
@jpenilla jpenilla deleted the userdev-pipeline-rewrite branch December 27, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paperweight-userdev v2 fails to build multi-module project
2 participants