Expose shutdownInProgress to the API. #1485
Merged
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4drian3d
approved these changes
Jan 21, 2025
|
Any hope of getting this merged? |
pull bot
pushed a commit
to WiIIiam278/Velocity
that referenced
this pull request
Jan 26, 2025
Co-authored-by: kyngs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple PR to expose whether the proxy is currently shutting down or not.
This can be useful for example in the listener for a DisconnectEvent, which is called for every player on proxy shutdown.
If this is intentional and you have no intent of changing this, close this PR.
The ProxyShutdownEvent is not a substitute for this, as it gets called after all players have been kicked when the proxy shuts down.