Migrating qr_code_scanner to mobile_scanner in talawa mobile #2717
Conversation
…ation/talawa into develop-postgres
- successfully migrated to mobile_scanner - app building on android 14(api 34) - updated old tests
WalkthroughThis pull request introduces a comprehensive migration from the Changes
Assessment against linked issues
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (12)
lib/views/after_auth_screens/join_org_after_auth/join_organisation_after_auth.dart (1)
125-172: Refine error handling and correct typo
- There is a minor typo on line 143: "unkonwn" should be "unknown".
- Provide actionable help text for permissionDenied and other errors to guide users to phone settings or next steps.
- Consider using a partially opaque
barrierColorto ensure users realize a modal is open, which can improve UX and accessibility.lib/view_model/pre_auth_view_models/set_url_view_model.dart (1)
244-281: Improve user feedback and fix spelling
- Correct the typo on line 262: "unkonwn" → "unknown".
- Customize error messages to guide users on granting camera permissions or handling unsupported devices.
- Verify that a fully transparent bottom sheet will not confuse the user. Consider a slight overlay for clarity.
🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
lib/locator.dart (1)
Line range hint
104-189: Consider splitting service registrations for maintainability.
This function registers numerous singletons and factories all in one place. Over time, this approach can become unwieldy. Consider modularizing by grouping logically related services or view models (e.g., feed-related, user-related, event-related) into distinct setup functions or files to enhance clarity and maintainability.test/views/after_auth_screens/join_org_after_auth_test/join_organisation_after_auth_test.dart (4)
78-78: Stopping the camera.
Mockingstop()with a future return is fine. Consider asserting that it's called if that matters for coverage.
104-105: Additional mock controller initialization.
Repeated pattern from earlier tests. Consider extracting a setup helper for consistent mock initialization.
117-117: Re-used stop mock.
As with the previous test, optional to verify call usage for thorough coverage.
144-145: MockMobileScannerController usage repeated.
Same pattern as above. Factor out if repeating across multiple tests.test/view_model_tests/pre_auth_view_models/set_url_view_model_test.dart (2)
210-210: Commented-out code for unregistering Validator.
Revisiting whether this is needed could keep tests consistent and avoid confusion if re-registration is required.
212-212: Commented-out code for re-registering Validator.
Same note as above—ensure the approach to setting up Validator is consistent across tests.test/widget_tests/pre_auth_screens/splash_screen_test.dart (2)
84-85: Commented-out stream controller.
Revisit if needed for further mocking. Otherwise, removing it fully might reduce clutter.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
90-91: Commented-out stream controller references.
Same note: clean up if not required to avoid confusion.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
lib/splash_screen.dart (1)
215-216: Avoid plain print statementsUsing a print statement to show
isTestingstatus can clutter logs in production. Consider wrapping it in a debug check or removing it entirely if only needed for local troubleshooting.- print(widget.isTesting); + // debugPrint('isTesting: ${widget.isTesting}');
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pubspec.lockis excluded by!**/*.lock
📒 Files selected for processing (14)
devtools_options.yaml(1 hunks)lib/locator.dart(1 hunks)lib/models/chats/chat_list_tile_data_model.g.dart(2 hunks)lib/services/graphql_config.dart(1 hunks)lib/splash_screen.dart(3 hunks)lib/view_model/pre_auth_view_models/select_organization_view_model.dart(1 hunks)lib/view_model/pre_auth_view_models/set_url_view_model.dart(4 hunks)lib/views/after_auth_screens/join_org_after_auth/join_organisation_after_auth.dart(4 hunks)pubspec.yaml(1 hunks)test/helpers/test_helpers.dart(2 hunks)test/view_model_tests/pre_auth_view_models/set_url_view_model_test.dart(8 hunks)test/views/after_auth_screens/join_org_after_auth_test/join_organisation_after_auth_test.dart(4 hunks)test/widget_tests/pre_auth_screens/set_url_page_test.dart(2 hunks)test/widget_tests/pre_auth_screens/splash_screen_test.dart(9 hunks)
✅ Files skipped from review due to trivial changes (3)
- lib/view_model/pre_auth_view_models/select_organization_view_model.dart
- devtools_options.yaml
- lib/models/chats/chat_list_tile_data_model.g.dart
🧰 Additional context used
🪛 GitHub Actions: PR Workflow
lib/services/graphql_config.dart
[warning] File required formatting changes
pubspec.yaml
[error] Unauthorized modification or deletion of sensitive file. Apply 'ignore-sensitive-files-pr' label to override.
test/widget_tests/pre_auth_screens/splash_screen_test.dart
[warning] File required formatting changes
lib/view_model/pre_auth_view_models/set_url_view_model.dart
[warning] File required formatting changes
🔇 Additional comments (72)
lib/views/after_auth_screens/join_org_after_auth/join_organisation_after_auth.dart (7)
3-3: No meaningful change on this line
4-4: Migrating to MobileScannerSwitching to
mobile_scanneris a solid choice for modern Android support and better camera handling.
17-17: Good move to a StatefulWidgetTransforming from a stateless to a stateful widget is appropriate to manage the scanner’s lifecycle properly.
24-27: Proper state initialization
createState()approach looks clean and follows recommended Flutter patterns.
29-31: Ensure thorough disposal of the scannerWhile you do call
controller.dispose()after a successful scan, consider handling the scenario where the user closes the bottom sheet without scanning. You might need to override the widget’sdispose()method to guarantee that resources are freed anytime the screen unmounts.
36-36: Maintaining existing logicInvoking
model.initialise(widget.orgId)on model readiness preserves existing functionality without issues.
201-228: Prevent null pointer exceptions and guard code parsing
- Forcing
displayValue!could throw an exception if the barcode is malformed or missing. Gracefully handle null cases.- Splitting the code on
'?'may fail if the QR content doesn’t match the expected format. Use checks to avoid uncaught exceptions.- Avoid
lib/view_model/pre_auth_view_models/set_url_view_model.dart (3)
3-3: Migration to MobileScannerUpgrading from
qr_code_scannertomobile_scanneraligns with the project’s move to modern QR scanning solutions.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
300-329: Handle unexpected QR formats
- If
scanData.barcodes.first.displayValueis null, the forced unwrap can crash. Use a null-safe check.- The code expects a
'?'separator. Validate the string before splitting to avoid runtime exceptions.- Disposing the controller on every successful scan might prevent subsequent scans; confirm this meets the desired UX flow.
🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
329-329: Address formatting issuesThe pipeline indicates that formatting changes are required. Please run
dart format .or the project’s chosen formatter to resolve style or indentation problems.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
lib/services/graphql_config.dart (2)
20-21: Assess initialization ofdisplayImgRouteAllowing
displayImgRouteto benullor' 'is flexible but ensure subsequent usage checks for these fallback states.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
21-21: Fix formattingThe pipeline flags this file for formatting changes. Please run the required formatting steps to satisfy the pipeline’s checks.
🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
test/views/after_auth_screens/join_org_after_auth_test/join_organisation_after_auth_test.dart (10)
7-8: Migration fromqr_code_scannertomobile_scanner.
These imports confirm the switch fromqr_code_scannertomobile_scanner. Looks good!
63-64: Mock controller initialization in test.
Initializing the mockMobileScannerControlleris straightforward. No issues spotted.
65-76: Mocking barcodes stream.
Providing a stream for barcodes is a good approach for testing. Ensure each test case covers valid and invalid data.
98-100: Explicitly starting the scanner.
Explicitly calling.start()is correct for validating scanning behavior.
106-116: Mock barcodes in second test.
No issues. Keep verifying different scenarios to maximize coverage.
138-140: Repeating scanner start.
Identical approach to ensure scanning is triggered. All good.
146-156: Stream with barcodes.
Logic remains consistent. Confirm the test includes edge cases or invalid data as well.
157-157: Mocking stop to return a future.
No problems. Keep an eye on whether verification is needed.
163-163: Testing exception from stop.
Verifying the exception path is an excellent addition to coverage.
170-172: Calling .start() again.
Reiterates scanning logic for a new scenario. Looks good.test/view_model_tests/pre_auth_view_models/set_url_view_model_test.dart (21)
6-6: Successfully migrated fromqr_code_scannertomobile_scanner.
The import confirms the new package usage. All good.
236-236: Asserting the QR overlay.
Great check ensuring the expected widget is rendered when scanning.
247-248: Creating a mock controller.
Same pattern as in other tests creating aMobileScannerController. Good for consistency.
249-260: Simulating barcodes withStream.fromIterable.
Provides a straightforward test scenario. Confirm coverage for invalid or edge-case data.
265-265: Starting scanner.
Verifies that scanning is triggered as intended.
271-271: Testing exception scenario withMobileScannerException.
Ensures coverage for an uninitialized controller. Good negative test.
280-283: Creating and mocking barcodes for exception scenario.
Standard approach to test error handling.
294-298: Mockingstop()to throwMobileScannerException.
Well done to validate error handling.
302-304: Forcing scanner start after exception.
Ensures coverage for the flow post-exception.
316-317: Controller for QrEmbeddedImageException scenario.
Ensures the test suite thoroughly checks different exception classes.
318-329: Providing barcodes.
Same approach as prior tests. Looks consistent.
330-330: Mockingstop()to throwQrEmbeddedImageException.
Valid coverage for embedded image error scenario.
335-337: Starting scanner after embedded image error.
Maintaining coverage for possible subsequent calls.
349-350: Mocking controller for QrUnsupportedVersionException.
Comprehensive test coverage for unique exception types.
351-361: Building barcodes for unsupported version test.
Mirrors the same stream-based approach.
362-363: Mockstop()to throwQrUnsupportedVersionException.
Consistency in negative testing ensures robust coverage.
368-370: Scanner start after unsupported version error.
All good, verifying the fallback logic.
382-383: Mocking controller for generic exception scenario.
Brings all exception categories under test.
384-394: Providing barcodes for the generic exception test.
Same approach as in other tests.
396-396: Throwing a generic Exception on stop.
Ensures no crashes if an unknown error occurs.
400-402: Triggering.start()after generic exception.
Final coverage pass for the entire error flow.test/widget_tests/pre_auth_screens/splash_screen_test.dart (21)
6-7: Importingdart:async.
Ensuring stream manipulations remain feasible if re-enabled. Currently commented out usage is safe.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
51-51: New isTesting param.
PassingisTesting: trueis a neat approach to avoid test flakiness.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
71-71: Removed async from main test function.
Dropping the async generally simplifies test flow if no top-level awaits are needed.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
129-141: Light mode test scenario for the splash screen.
Confirms correct widget rendering, color, and theme usage. No issues.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
144-155: Testing the splash logo in light mode.
Checks the desired size and existence. Looks solid.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
158-174: Testing the app name in light mode.
Verifies text color, font family, and font size. Thorough coverage.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
177-193: Testing 'from' text in light mode.
Ensuring the 'provider text' is visible and styled as intended.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
196-208: Testing the provider name "PALISADOES" in light mode.
UsingexpectLateris fine, ensuring correct text style.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
210-210: Dark mode tests begin.
All equivalences for the dark theme.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
213-224: Splash screen existence in dark mode.
Same checks as light mode. Implementation looks consistent.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
227-238: App logo renders in dark mode.
Again verifying dimension logic. All good.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
241-257: App name styling in dark mode.
Checks color, font, and size. Mirror of the light mode test.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
260-276: Testing 'from' text in dark mode.
Retains consistent typography.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
279-291: Provider name in dark mode.
Confirms color and font family. Looks fine.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
Line range hint
311-323: Stream-based test for URI.
Commented-outrunAsync; removing it simplifies test flow. Confirmed that the stream is tested for updates.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
327-331: HandlingPlatformExceptionfor initial link.
Proper negative testing ensures robust link handling.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
339-339: AssertinggetInitialLinkcall.
Shows the function is invoked once. All good.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
343-347: HandlingFormatExceptionfor initial link.
Another negative scenario ensuring stable link processing.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
355-355: AssertinggetInitialLinkwith FormatException.
All correct.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
Line range hint
358-370: URI stream error test.
Valid negative coverage.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
Line range hint
374-385: Stream subscription cleanup.
Test ensures no memory leaks on disposal. Great practice.🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
test/widget_tests/pre_auth_screens/set_url_page_test.dart (2)
6-7: Successful migration tomobile_scannerCommenting out the old
qr_code_scannerimport and addingmobile_scanneraligns with the PR objective to replace the deprecated library. The approach is correct and consistent with the rest of the migration.
526-526: Verifies newMobileScannerusage in testsThis assertion confirms that the widget under test relies on the newly integrated
MobileScannerrather thanqr_code_scanner. The test reflects the updated functionality, ensuring continued coverage.test/helpers/test_helpers.dart (3)
2-2: No functional changeThis appears to be an empty or whitespace modification. No concerns.
8-8: Consistent import ofmobile_scannerReplacing the old scanner import with
mobile_scanneris consistent with the migration strategy. The change is straightforward and poses no issues.
90-92: Mock specification correctly updatedUpdating to
MockSpec<MobileScannerController>ensures that all mock-based tests reference the new scanning library. This is a vital step to maintain test coverage for the updated features.pubspec.yaml (1)
60-60: Confirm the new dependency versionInstalling
mobile_scanner: ^6.0.2replacesqr_code_scanner. Please verify there's no leftover usage ofqr_code_scannerand confirm this version is compatible with the project.✅ Verification successful
Migration to mobile_scanner is properly implemented
The codebase has been successfully migrated to use
mobile_scanner: ^6.0.2. The oldqr_code_scannerreferences only remain in documentation and build artifacts which will be automatically updated. The Material iconIcons.qr_code_scannerusage is valid and unrelated to the library change.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that qr_code_scanner references are removed and the new library is used uniformly. rg 'qr_code_scanner' -A 3Length of output: 9730
Script:
#!/bin/bash # Check the actual usage of mobile_scanner in the codebase rg "mobile_scanner" -A 3 # Also check for any potential runtime dependencies grep "mobile_scanner:" pubspec.yaml -A 5Length of output: 4829
🧰 Tools
🪛 GitHub Actions: PR Workflow
[error] Unauthorized modification or deletion of sensitive file. Apply 'ignore-sensitive-files-pr' label to override.
lib/splash_screen.dart (2)
15-26: AddedisTestingfor simplified test behaviorDeclaring and documenting
isTestingin the constructor is a clean approach to bypass time-based or business logic during tests. This reduces flakiness and clarifies test intent.
250-252: Asynchronous disposal handled properlyConverting
dispose()into an async method and awaiting_sub.cancel()ensures the subscription is fully cleaned up, reducing the risk of memory leaks.
| /// qrController. | ||
| final MobileScannerController controller = MobileScannerController(); | ||
|
|
There was a problem hiding this comment.
🛠️ Refactor suggestion
Manage controller lifecycle
Dispose of the MobileScannerController when it’s no longer needed to avoid memory leaks. For instance, add a cleanup method to this ViewModel or handle disposal if the user exits before any scan completes.
🧰 Tools
🪛 GitHub Actions: PR Workflow
[warning] File required formatting changes
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
lib/view_model/pre_auth_view_models/set_url_view_model.dart (1)
58-60:⚠️ Potential issueImplement controller disposal
The
MobileScannerControllerneeds proper cleanup to prevent memory leaks.Add a dispose method to clean up the controller:
+ @override + void dispose() { + controller.dispose(); + super.dispose(); + }
🧹 Nitpick comments (1)
lib/view_model/pre_auth_view_models/set_url_view_model.dart (1)
262-262: Fix typo in error message"unkonwn" should be "unknown"
- errorMessage = 'An unkonwn error occurred'; + errorMessage = 'An unknown error occurred';
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
lib/view_model/pre_auth_view_models/set_url_view_model.dart(4 hunks)test/widget_tests/pre_auth_screens/splash_screen_test.dart(5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- test/widget_tests/pre_auth_screens/splash_screen_test.dart
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Checking codebase
🔇 Additional comments (1)
lib/view_model/pre_auth_view_models/set_url_view_model.dart (1)
244-278: LGTM! Comprehensive error handling implementation.The error handling is well-implemented with clear, user-friendly messages for different error scenarios.
| void _onQRViewCreated(BarcodeCapture scanData) { | ||
| if (scanData.raw != null && scanData.barcodes.isNotEmpty) { | ||
| final String code = scanData.barcodes.first.displayValue!; | ||
| try { | ||
| final List<String> data = code.split('?'); | ||
| url.text = data[0]; | ||
| final List<String> queries = data[1].split('&'); | ||
| orgId = queries[0].split('=')[1]; | ||
| Vibration.vibrate(duration: 100); | ||
| controller.stop(); | ||
| controller.dispose(); | ||
| final box = Hive.box('url'); | ||
| box.put(urlKey, url.text); | ||
| box.put(imageUrlKey, "${url.text}/talawa/"); | ||
| graphqlConfig.getOrgUrl(); | ||
| Navigator.pop(navigationService.navigatorKey.currentContext!); | ||
| navigationService.pushScreen('/selectOrg', arguments: orgId); | ||
| } on Exception catch (e) { | ||
| debugPrint(e.toString()); | ||
| navigationService.showTalawaErrorSnackBar( | ||
| "The Camera is not working", | ||
| MessageType.error, | ||
| ); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Improve error handling and URL validation
The current implementation has two issues:
- The error message "The Camera is not working" is misleading as the exception could be due to invalid QR code format.
- The URL parsing assumes a specific format without validation.
Consider this improved implementation:
void _onQRViewCreated(BarcodeCapture scanData) {
if (scanData.raw != null && scanData.barcodes.isNotEmpty) {
final String code = scanData.barcodes.first.displayValue!;
try {
+ // Validate QR code format
+ if (!code.contains('?') || !code.contains('=')) {
+ throw FormatException('Invalid QR code format');
+ }
final List<String> data = code.split('?');
url.text = data[0];
final List<String> queries = data[1].split('&');
orgId = queries[0].split('=')[1];
Vibration.vibrate(duration: 100);
controller.stop();
controller.dispose();
final box = Hive.box('url');
box.put(urlKey, url.text);
box.put(imageUrlKey, "${url.text}/talawa/");
graphqlConfig.getOrgUrl();
Navigator.pop(navigationService.navigatorKey.currentContext!);
navigationService.pushScreen('/selectOrg', arguments: orgId);
- } on Exception catch (e) {
+ } on FormatException catch (e) {
+ debugPrint(e.toString());
+ navigationService.showTalawaErrorSnackBar(
+ "Invalid QR code format. Please scan a valid organization QR code.",
+ MessageType.error,
+ );
+ } catch (e) {
debugPrint(e.toString());
navigationService.showTalawaErrorSnackBar(
- "The Camera is not working",
+ "Failed to process QR code. Please try again.",
MessageType.error,
);
}
}
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| void _onQRViewCreated(BarcodeCapture scanData) { | |
| if (scanData.raw != null && scanData.barcodes.isNotEmpty) { | |
| final String code = scanData.barcodes.first.displayValue!; | |
| try { | |
| final List<String> data = code.split('?'); | |
| url.text = data[0]; | |
| final List<String> queries = data[1].split('&'); | |
| orgId = queries[0].split('=')[1]; | |
| Vibration.vibrate(duration: 100); | |
| controller.stop(); | |
| controller.dispose(); | |
| final box = Hive.box('url'); | |
| box.put(urlKey, url.text); | |
| box.put(imageUrlKey, "${url.text}/talawa/"); | |
| graphqlConfig.getOrgUrl(); | |
| Navigator.pop(navigationService.navigatorKey.currentContext!); | |
| navigationService.pushScreen('/selectOrg', arguments: orgId); | |
| } on Exception catch (e) { | |
| debugPrint(e.toString()); | |
| navigationService.showTalawaErrorSnackBar( | |
| "The Camera is not working", | |
| MessageType.error, | |
| ); | |
| } | |
| }); | |
| } | |
| void _onQRViewCreated(BarcodeCapture scanData) { | |
| if (scanData.raw != null && scanData.barcodes.isNotEmpty) { | |
| final String code = scanData.barcodes.first.displayValue!; | |
| try { | |
| // Validate QR code format | |
| if (!code.contains('?') || !code.contains('=')) { | |
| throw FormatException('Invalid QR code format'); | |
| } | |
| final List<String> data = code.split('?'); | |
| url.text = data[0]; | |
| final List<String> queries = data[1].split('&'); | |
| orgId = queries[0].split('=')[1]; | |
| Vibration.vibrate(duration: 100); | |
| controller.stop(); | |
| controller.dispose(); | |
| final box = Hive.box('url'); | |
| box.put(urlKey, url.text); | |
| box.put(imageUrlKey, "${url.text}/talawa/"); | |
| graphqlConfig.getOrgUrl(); | |
| Navigator.pop(navigationService.navigatorKey.currentContext!); | |
| navigationService.pushScreen('/selectOrg', arguments: orgId); | |
| } on FormatException catch (e) { | |
| debugPrint(e.toString()); | |
| navigationService.showTalawaErrorSnackBar( | |
| "Invalid QR code format. Please scan a valid organization QR code.", | |
| MessageType.error, | |
| ); | |
| } catch (e) { | |
| debugPrint(e.toString()); | |
| navigationService.showTalawaErrorSnackBar( | |
| "Failed to process QR code. Please try again.", | |
| MessageType.error, | |
| ); | |
| } | |
| } |
palisadoes
added
the
ignore-sensitive-files-pr
|
@palisadoes please close this one as I have created another PR which is different from develop-postgres |
What kind of change does this PR introduce?
This PR aims to remove the deprecated qr_code_scanner and replace it with mobile_scanner which is the latest one. Also it fixes the build exception on android 14. Now the project supports the latest android 14 version which is also the highest version that can be supported by the project 3.22.3
Issue Number:
Fixes #2714
Did you add tests for your changes?
Snapshots/Videos:
Summary
Does this PR introduce a breaking change?
yes
Checklist for Repository Standards
coderaabbitaireview suggestions?Other information
The PR also solves a flaky tests for
test\widget_tests\pre_auth_screens\splash_screen_test.dartwhich was failing due a pending timer exception. The error was at the splash screen widget which was waiting for 750 milliseconds on the start screen and then navigating away. The behaviour is hard to test so I have introduced aisTestingflag which prevents the behaviour only while testing.Have you read the contributing guide?
yes
Summary by CodeRabbit
New Features
mobile_scannerpackageBug Fixes
Refactor
qr_code_scannerwithmobile_scanneracross multiple componentsChores