-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Developed the business logic of offline detection mechanism (GSoC) #2523
Developed the business logic of offline detection mechanism (GSoC) #2523
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2523 +/- ##
===========================================
+ Coverage 96.82% 96.85% +0.02%
===========================================
Files 155 156 +1
Lines 7908 7950 +42
===========================================
+ Hits 7657 7700 +43
+ Misses 251 250 -1 ☔ View full report in Codecov by Sentry. |
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
@noman2002, @DMills27 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What kind of change does this PR introduce?
This PR introduces a
ConnectivityService
into the code base. This service is responsible for detecting the network connectivity status of the mobile device.Issue Number:
Fixes #2520
Did you add tests for your changes?
Yes
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
After merging this PR.
ConnectivityService
provides an API to access the connectivity status and trigger appropriate actions.ConnectivityService
uses theConnectivity_plus
package._handleOnline
, and_handleOffline
methods are intentionally left blank for future use.Does this PR introduce a breaking change?
No
Other information
This PR is just the business logic of the
offline detection mechanism
feature.The UI code to replicate the network changes and integrate this business logic will be raised in a subsequent PR within one week time.
Have you read the contributing guide?
Yes