Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed loading indicator in the pinned_post and organization feed (pinned_post_screen) and made it circular and normal indicator. #2426

Closed
wants to merge 12 commits into from

Conversation

M-SAI-SOORYA
Copy link

What kind of change does this PR introduce?

Fixing loading indicator in the pinned_post and organization feed (pinned_post_screen) and made it circular and normal indicator. nad adjusted the UI and also added tests to the changes.

Issue Number:

Fixes #
#2391

Did you add tests for your changes?

Yes

Snapshots/Videos:

WhatsApp.Video.2024-03-17.at.18.10.38_97394686.mp4

Does this PR introduce a breaking change?
This is just an UI change and not code functionality change.

Have you read the contributing guide?

Yes

Fixed in the loading indicator in the organization feed where i adjusted UI of circularprogressindicator and adjusted the aspect ratio
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@Cioppolo14
Copy link
Contributor

@M-SAI-SOORYA Please fix the failing checks.

@M-SAI-SOORYA
Copy link
Author

@Cioppolo14 as per the checks , i fixed , can you please review the PR now.

@dhanagopu
Copy link

@noman2002 @Kevoniat Can you review this PR?

@palisadoes
Copy link
Contributor

This is an update on the PR merging freeze:

  1. In the next few hours we will be merging the develop-userTypeFix branch into the develop branch.
  2. The develop-userTypeFix branch was created to fix a long standing design flaw where Admins were Admins of all organizations, not specific ones.
  3. The userType field has been removed from the User collection and it has been replaced by an appUserProfileId field.
    1. This field is null if the user isn’t registered to use the apps. This will help people to add users manually during the event checkin process, or if an Admin wants to manually add someone in the Admin dashboard.
    2. When not null the AppUserProfileID will reference a AppUserProfile collection with App related information such as the organizations for which a user may be an Admin.
    3. The updated schema can be found here https://github.com/PalisadoesFoundation/talawa-api/blob/develop-userTypeFix/schema.graphql
    4. This is the parent issue that we have been using to track progress:
      1. PARENT ISSUE: Fix the usage of userType talawa-api#1965
  4. This merge will cause some conflicts in your PR.

We decided to do this at the beginning of the weekend to give us all time to adjust PR code and create bug fixes that may arise.

Update your code at or after midnight GMT on the morning of March 23, 2024. (5:30am IST).

If your PRs have already been approved, request a re-review after fixing the conflicts and refactoring to the new AppUserProfileID methodology.

lib/widgets/pinned_post.dart Outdated Show resolved Hide resolved
lib/views/after_auth_screens/feed/pinned_post_screen.dart Outdated Show resolved Hide resolved
@Cioppolo14
Copy link
Contributor

@M-SAI-SOORYA Please fix the failing tests.

Copy link

github-actions bot commented Apr 5, 2024

This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No pull request activity label Apr 5, 2024
@palisadoes
Copy link
Contributor

Closing as abandoned. You can request it to be reopened if you'd like

@palisadoes palisadoes closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity No pull request activity Ready 4 PR Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants