-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed loading indicator in the pinned_post and organization feed (pinned_post_screen) and made it circular and normal indicator. #2426
Conversation
Fixed in the loading indicator in the organization feed where i adjusted UI of circularprogressindicator and adjusted the aspect ratio
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
@M-SAI-SOORYA Please fix the failing checks. |
@Cioppolo14 as per the checks , i fixed , can you please review the PR now. |
@noman2002 @Kevoniat Can you review this PR? |
This is an update on the PR merging freeze:
We decided to do this at the beginning of the weekend to give us all time to adjust PR code and create bug fixes that may arise. Update your code at or after midnight GMT on the morning of March 23, 2024. (5:30am IST). If your PRs have already been approved, request a re-review after fixing the conflicts and refactoring to the new |
@M-SAI-SOORYA Please fix the failing tests. |
This pull request did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
Closing as abandoned. You can request it to be reopened if you'd like |
What kind of change does this PR introduce?
Fixing loading indicator in the pinned_post and organization feed (pinned_post_screen) and made it circular and normal indicator. nad adjusted the UI and also added tests to the changes.
Issue Number:
Fixes #
#2391
Did you add tests for your changes?
Yes
Snapshots/Videos:
WhatsApp.Video.2024-03-17.at.18.10.38_97394686.mp4
Does this PR introduce a breaking change?
This is just an UI change and not code functionality change.
Have you read the contributing guide?
Yes