-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(post): fixed the profile picture feature for users liking and commenting on post #2355
fix(post): fixed the profile picture feature for users liking and commenting on post #2355
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
@Abhisheksainii Please fix the failing tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do that requested changes.
CircleAvatar( | ||
backgroundImage: NetworkImage(comment.creator?.image ?? "")), | ||
Expanded( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a fallback image to this as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do it, thanks!
@Abhisheksainii Any update on this ? |
@Abhisheksainii Are you working on this? |
Not right now |
Closing due to inactivity |
What kind of change does this PR introduce?
bugfix - Profile Images of users who have liked and commented is not visible.
Issue Number: #2279
Fixes #2279
Did you add tests for your changes?
No, tests for services and models were already there.
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Profile Images of users who have liked and commented on the post is not visible and was causing bad user experience.
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?