Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for access_request_screen_test.dart #2222

Closed
wants to merge 8 commits into from
Closed

Write tests for access_request_screen_test.dart #2222

wants to merge 8 commits into from

Conversation

SatwikMohan
Copy link

What kind of change does this PR introduce?

This change included the Unittest for access_request_screen.dart

Issue Number: #2151

Fixes #2151

Did you add tests for your changes?

Yes I have added tests for SendAccessRequest Widget in the access_request_screen.dart file

Snapshots/Videos: Test coverage

Screenshot (350)

Summary

Tests for access_request_screen are created for which files access_request_screen_test.dart, test_helper.dart and test_helper.mocks.dart are created and updated respectively.
The test_helper is updated for AccessRequestScreenViewModel class and correspondingly the test_helper.mocks.dart is updated on calling the build_runner command.

Does this PR introduce a breaking change?

No, this does not introduce any major changes to the codebase.

Have you read the contributing guide?

Yes, I have followed the guidelines.

Copy link

github-actions bot commented Dec 7, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@palisadoes
Copy link
Contributor

palisadoes commented Dec 7, 2023

You have added a package that we don't use for mocks.

  • mocktail: ^1.0.1

Use our existing standard which is mockito

Please resubmit with no changes to the packages.

Closing.

@palisadoes palisadoes closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for access_request_screen.dart
2 participants