Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write tests for access_request_screen.dart and join_org_after_auth.dart #2212

Closed
wants to merge 5 commits into from

Conversation

SatwikMohan
Copy link

What kind of change does this PR introduce?

This change included the Unittest for access_request_screen.dart

Issue Number: #2151

Fixes: #2151

Did you add tests for your changes?

Yes I have added tests

Summary

Tests for access_request_screen are created for which files access_request_screen_test.dart, access_request_screen_test.mocks.dart are created

Does this PR introduce a breaking change?

No, this does not introduce any major changes to the codebase.

Have you read the contributing guide?

Yes, I have followed the guidelines.

Copy link

github-actions bot commented Dec 4, 2023

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@noman2002
Copy link
Member

@SatwikMohan Why there are so many file changes for test ??

@SatwikMohan
Copy link
Author

@noman2002 Sir when I committed I forgot to update my fork so I first update my fork and then open a pull request. While working on the test I used the command dart pub add build_runner build which added .mock.dart file and also updated all the generating files like .g.dart.

Copy link
Author

@SatwikMohan SatwikMohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of change does this PR introduce?

This change included the Unittest for join_org_after_auth.dart

Issue Number: #2152

Fixes: #2152

Did you add tests for your changes?

Yes I have added tests

Summary

Tests for join_org_after_auth are created for which files join_org_after_auth_test.dart, join_org_after_auth_test.mocks.dart are created

Does this PR introduce a breaking change?

No, this does not introduce any major changes to the codebase.

Have you read the contributing guide?

Yes, I have followed the guidelines.

@SatwikMohan SatwikMohan changed the title Write tests for access_request_screen.dart Write tests for access_request_screen.dart and join_org_after_auth.dart Dec 5, 2023
@SatwikMohan
Copy link
Author

SatwikMohan commented Dec 5, 2023

@noman2002 Sir I think I have again made a mistake while creating a pull request regarding test for join_org_after_auth.dart issue.
A new pull request is not created but it committed in the previous pull request.
Sir please guide me if I have made a mistake.

@noman2002
Copy link
Member

@SatwikMohan I am closing this. Please submit a new PR.

@noman2002 noman2002 closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for access_request_screen.dart
2 participants