-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write tests for access_request_screen.dart and join_org_after_auth.dart #2212
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
@SatwikMohan Why there are so many file changes for test ?? |
@noman2002 Sir when I committed I forgot to update my fork so I first update my fork and then open a pull request. While working on the test I used the command dart pub add build_runner build which added .mock.dart file and also updated all the generating files like .g.dart. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of change does this PR introduce?
This change included the Unittest for join_org_after_auth.dart
Issue Number: #2152
Fixes: #2152
Did you add tests for your changes?
Yes I have added tests
Summary
Tests for join_org_after_auth are created for which files join_org_after_auth_test.dart, join_org_after_auth_test.mocks.dart are created
Does this PR introduce a breaking change?
No, this does not introduce any major changes to the codebase.
Have you read the contributing guide?
Yes, I have followed the guidelines.
@noman2002 Sir I think I have again made a mistake while creating a pull request regarding test for join_org_after_auth.dart issue. |
@SatwikMohan I am closing this. Please submit a new PR. |
What kind of change does this PR introduce?
This change included the Unittest for access_request_screen.dart
Issue Number: #2151
Fixes: #2151
Did you add tests for your changes?
Yes I have added tests
Summary
Tests for access_request_screen are created for which files access_request_screen_test.dart, access_request_screen_test.mocks.dart are created
Does this PR introduce a breaking change?
No, this does not introduce any major changes to the codebase.
Have you read the contributing guide?
Yes, I have followed the guidelines.