Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing logic error in talawa_plugin_provider.dart for visibility of plugins #2168

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

Dante291
Copy link
Contributor

What kind of change does this PR introduce?

Fixing logic error in this file.

Issue Number:

Fixes #2141

Did you add tests for your changes?

No

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ee0c25) 79.85% compared to head (5d547e3) 79.86%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2168      +/-   ##
===========================================
+ Coverage    79.85%   79.86%   +0.01%     
===========================================
  Files          152      152              
  Lines         7456     7450       -6     
===========================================
- Hits          5954     5950       -4     
+ Misses        1502     1500       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes
Copy link
Contributor

Please update the corresponding test file for your PR to get its test coverage up to 100%

@Dante291
Copy link
Contributor Author

@noman2002 @palisadoes review please.

@Dante291
Copy link
Contributor Author

@palisadoes @noman2002 The reason why PR target workflow is getting failed is because of this issue in first-interaction.

@palisadoes
Copy link
Contributor

@palisadoes @noman2002 The reason why PR target workflow is getting failed is because of this issue in first-interaction.

Thanks. I've assigned reviewers. Please work with them to get this merged.

@palisadoes
Copy link
Contributor

@SiddheshKukade please take a look

@Dante291
Copy link
Contributor Author

Dante291 commented Dec 4, 2023

@Ayush0Chaudhary Could you review this and get this merge.

@palisadoes palisadoes merged commit f13cc93 into PalisadoesFoundation:develop Dec 4, 2023
7 checks passed
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
…lugins (PalisadoesFoundation#2168)

* Fixing logic error in talawa_plugin_provider.dart for visibility of plugins

* Fixing linting errors

* Fixing coverage

* Fixing coverage

* Fixing coverage

* Fixing

* Fixing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic error in talawa_plugin_provider.dart file for the visibility of a plugin.
3 participants