-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing logic error in talawa_plugin_provider.dart for visibility of plugins #2168
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2168 +/- ##
===========================================
+ Coverage 79.85% 79.86% +0.01%
===========================================
Files 152 152
Lines 7456 7450 -6
===========================================
- Hits 5954 5950 -4
+ Misses 1502 1500 -2 ☔ View full report in Codecov by Sentry. |
Please update the corresponding test file for your PR to get its test coverage up to 100% |
@noman2002 @palisadoes review please. |
@palisadoes @noman2002 The reason why PR target workflow is getting failed is because of this issue in first-interaction. |
Thanks. I've assigned reviewers. Please work with them to get this merged. |
@SiddheshKukade please take a look |
@Ayush0Chaudhary Could you review this and get this merge. |
…lugins (PalisadoesFoundation#2168) * Fixing logic error in talawa_plugin_provider.dart for visibility of plugins * Fixing linting errors * Fixing coverage * Fixing coverage * Fixing coverage * Fixing * Fixing
What kind of change does this PR introduce?
Fixing logic error in this file.
Issue Number:
Fixes #2141
Did you add tests for your changes?
No
Have you read the contributing guide?
Yes