-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for edit_event_page.dart #2130
Conversation
…event_page to 100%
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2130 +/- ##
===========================================
+ Coverage 77.29% 78.78% +1.48%
===========================================
Files 152 152
Lines 7456 7456
===========================================
+ Hits 5763 5874 +111
+ Misses 1693 1582 -111 ☔ View full report in Codecov by Sentry. |
Please fix the first comment so that each issue listed automatically closes. The PR_GUIDELINES.md file has details. Please also fill in the template for the pull request as completely as you can. It greatly helps others searching for code changes in future and helps others understand the summarized rationale for the work you have done |
@palisadoes is the comment good now? any follow ups? |
Please work with @aashimawadhwa on this PR. This week this contributor is working on assigning issues, assigning reviewers to PRs and answering general questions. |
Sure @palisadoes , got it. |
@aashimawadhwa please assign reviewers to this PR. |
@noman2002 @Ayush0Chaudhary please review this pr. |
What kind of change does this PR introduce?
This PR adds tests for edit_event_page.dart.
Issue Number:
Fixes #1517
Did you add tests for your changes?
yes
Snapshots/Videos:
If relevant, did you update the documentation?
No
Summary
https://github.com/PalisadoesFoundation/talawa/issues/1517
Does this PR introduce a breaking change?
No
Other information
Added tests to the edit_event_page.dart and increased its code coverage from 0% to 100%.
Have you read the contributing guide?
yes