Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for edit_event_page.dart #2130

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Tests for edit_event_page.dart #2130

merged 1 commit into from
Nov 22, 2023

Conversation

Azad99-9
Copy link
Contributor

@Azad99-9 Azad99-9 commented Nov 22, 2023

What kind of change does this PR introduce?

This PR adds tests for edit_event_page.dart.

Issue Number:

Fixes #1517

Did you add tests for your changes?

yes

Snapshots/Videos:

If relevant, did you update the documentation?

No

Summary

https://github.com/PalisadoesFoundation/talawa/issues/1517

Does this PR introduce a breaking change?

No

Other information

Added tests to the edit_event_page.dart and increased its code coverage from 0% to 100%.

Have you read the contributing guide?

yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4385f71) 77.29% compared to head (36ac99f) 78.78%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2130      +/-   ##
===========================================
+ Coverage    77.29%   78.78%   +1.48%     
===========================================
  Files          152      152              
  Lines         7456     7456              
===========================================
+ Hits          5763     5874     +111     
+ Misses        1693     1582     -111     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes
Copy link
Contributor

Please fix the first comment so that each issue listed automatically closes. The PR_GUIDELINES.md file has details.

Please also fill in the template for the pull request as completely as you can. It greatly helps others searching for code changes in future and helps others understand the summarized rationale for the work you have done

@Azad99-9
Copy link
Contributor Author

@palisadoes is the comment good now? any follow ups?

@palisadoes
Copy link
Contributor

Please work with @aashimawadhwa on this PR. This week this contributor is working on assigning issues, assigning reviewers to PRs and answering general questions.

@Azad99-9
Copy link
Contributor Author

Please work with @aashimawadhwa on this PR. This week this contributor is working on assigning issues, assigning reviewers to PRs and answering general questions.

Sure @palisadoes , got it.

@Azad99-9
Copy link
Contributor Author

@aashimawadhwa please assign reviewers to this PR.

@aashimawadhwa
Copy link
Member

@noman2002 @Ayush0Chaudhary please review this pr.

@palisadoes palisadoes merged commit c953170 into PalisadoesFoundation:develop Nov 22, 2023
7 checks passed
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests for edit_event_page.dart
4 participants