-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1535 Tests for Post services.dart #2103
Fixes #1535 Tests for Post services.dart #2103
Conversation
…into post_services.dart
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
@AyushRaghuvanshi Fix the failing test. |
@noman2002 It was not failing on my system. But the error seemed like, tests are trying to access the resource at the same time. |
@AyushRaghuvanshi The test is failing in this PR only. It is working fine in other. Please look into it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2103 +/- ##
===========================================
+ Coverage 76.43% 76.88% +0.45%
===========================================
Files 152 152
Lines 7438 7438
===========================================
+ Hits 5685 5719 +34
+ Misses 1753 1719 -34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
…oesFoundation#2103) * Add:Tests for post_service.dart * Fix: Format * Fix: lint issues * Add:Fixed Format * Add:Hive.deleteFromDisk() wherever Hive is used * Remove: Unused Hive Box
What kind of change does this PR introduce?
Wrote tests for post_services.dart
Issue Number:
Fixes #1535
Did you add tests for your changes?
Yes
Summary
Added Tests for the file
lib\services\post_service.dart
.Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes