-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement quick_fix for talawa_good_doc and enforce tab before None of params block #1754
implement quick_fix for talawa_good_doc and enforce tab before None of params block #1754
Conversation
@palisadoes please merge :) |
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
This may make sense to you as the developer, but the user will be ignorant of the requirement. @anwersayeed Please review this PR. |
Also, does the new auto-inserted text comply with the DartDoc standard? |
Yes it does. |
I had thought of it and have provided a descriptive template already (I thought it was descriptive :( ), because the errors generated are quite descriptive, so I thought of being lenient with the template at least. |
Codecov Report
@@ Coverage Diff @@
## develop #1754 +/- ##
========================================
Coverage 81.37% 81.37%
========================================
Files 144 144
Lines 7290 7290
========================================
Hits 5932 5932
Misses 1358 1358
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@palisadoes we already have the docs for our lint rules in Talawa-docs. The errors generated are descriptive too. We can also add a file to the codebase which shows all the possibilities of declarations and how to document them. What is your opinion? |
@palisadoes added URL to |
What kind of change does this PR introduce?
talawa_api_doc
custom lint rule. Now a template can be inserted with a few clicks to document the code easily.tab
space before theNone
of empty param list.Talawa Docs
in the error message itself.Issue Number:
Part of: #1646
Snapshots/Videos:
scr_quick_fix.mp4