-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1242 Create tests for create_event_page.dart #1472
Fixes #1242 Create tests for create_event_page.dart #1472
Conversation
9be8d02
to
a9c5148
Compare
The part which was not tested is in below ss the below loop return false for every value talawa/lib/view_model/after_auth_view_models/event_view_models/create_event_view_model.dart Lines 143 to 152 in 311b205
Thus the frontend can never be tested, as the list is always null |
@palisadoes @noman2002 @TheHazeEffect please review. |
@palisadoes the same check failed again, can you rerun the actions |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #1472 +/- ##
===========================================
+ Coverage 74.59% 75.26% +0.67%
===========================================
Files 146 146
Lines 7222 7221 -1
===========================================
+ Hits 5387 5435 +48
+ Misses 1835 1786 -49
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but we should keep the issue open to get it to 100%
What kind of change does this PR introduce?
Fixes #1242 Create tests for create_event_page.dart
Issue Number:
Fixes #1242
Did you add tests for your changes?
YES
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Fixes #1242 Create tests for create_event_page.dart
Does this PR introduce a breaking change?
NO
Other information
Have you read the contributing guide?
YES