Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Vite to 6.0.11 #3545

Merged

Conversation

JaiPannu-IITI
Copy link

@JaiPannu-IITI JaiPannu-IITI commented Feb 5, 2025

Description:

This PR upgrades Vite from 5.4.8 → 6.0.11 and resolves dependency conflicts by removing an unsupported package and updating others.

🔴Removed Package: [email protected]

This package does not support Vite 6 (vite@"^2.0.0 || ^3.0.0 || ^4.0.0 || ^5.0.0") and was causing installation errors (ERESOLVE).
It was only used in vitest.config.ts to polyfill the Node.js events module, which is not needed in our tests.

⚠️Updated with --legacy-peer-deps: vite-plugin-svgr

Changes Made:

  1. Upgraded Vite to 6.0.11 🆙
  2. Removed [email protected]
  3. Updated vite-plugin-svgr while bypassing peer dependency conflicts
  4. Modified vitest.config.ts to remove nodePolyfills()

Testing & Validation:

✅ docker-compose -f docker/docker-compose.dev.yaml --env-file .env up
✅ All tests passed via npm run test:vitest

Issue Reference:

Closes #3518

Merge Checklist:

  • Confirm Vite 6 works in all environments
  • Validate SVG imports are working correctly
  • Ensure no test failures due to polyfill removal
  • This PR ensures a clean upgrade to Vite 6 while removing unnecessary dependencies. Let me know if you need any further adjustments!

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Revised key build components and dependency management to streamline the build process and improve module handling.
    • Adjusted the underlying setup for development and production environments to enhance performance and overall stability for a smoother user experience.
    • Updated various dependencies to their latest versions, ensuring compatibility and improved functionality.

Copy link
Contributor

coderabbitai bot commented Feb 5, 2025

Walkthrough

The package.json file has been modified to restructure dependency declarations. Dependencies previously listed under the standard dependencies section—namely @vitejs/plugin-react, vite, and vite-plugin-node-polyfills—have been removed. In their place, updates and additions were made in the devDependencies section, which now includes an upgraded @vitejs/plugin-react, a newly added vite at version ^6.0.11, an updated vite-plugin-node-polyfills, and an updated vite-plugin-svgr. Additionally, the vitest.config.ts file has had the nodePolyfills plugin removed from its configuration.

Changes

File Change Summary
package.json - Dependencies: Removed @vitejs/plugin-react, vite, and vite-plugin-node-polyfills.
- DevDependencies: Added/updated @vitejs/plugin-react (from ^4.3.3 to ^4.3.4), added vite (^6.0.11), added vite-plugin-node-polyfills, updated vite-plugin-svgr (from ^4.2.0 to ^4.3.0).
vitest.config.ts - Removed nodePolyfills plugin from the plugins array.

Assessment against linked issues

Objective Addressed Explanation
Upgrade package vite from 5.4.14 to 6.0.11 (#3518)

Possibly related PRs

Poem

In a burrow deep in code, I hopped with glee,
Dependencies shuffled, now clean and free.
Vite’s new rhythm, a swift, upgraded beat,
With plugins in devDependencies, the setup’s neat!
Cheers from this rabbit—coding magic we shall meet!
🐰✨

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbaea36 and 5b46b05.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (2 hunks)
  • vitest.config.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Test Application
🔇 Additional comments (1)
vitest.config.ts (1)

7-7: LGTM! The removal of nodePolyfills plugin is appropriate.

The removal of the nodePolyfills plugin is in line with the Vite 6 upgrade requirements, and previous discussions confirm it wasn't critical for functionality.

Let's verify that the tests still run correctly without the Node.js events polyfill:

✅ Verification successful

🏁 Script executed:

#!/bin/bash
# Description: Verify test functionality after removing nodePolyfills plugin
# Test: Search for any direct usage of Node.js 'events' module that might need polyfilling

# Look for direct imports of 'events' module
rg -l "from ['|\"]events['|\"]" || echo "No direct 'events' imports found"

# Look for require('events') usage
rg -l "require\(['\"]events['\"]\)" || echo "No require('events') found"

Length of output: 229


LGTM: The removal of the nodePolyfills plugin is safe.

The shell script output confirms that there are no direct references to the Node.js 'events' module, which suggests that removing the polyfill doesn't adversely affect test functionality.

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Feb 5, 2025

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (00d3c15) to head (5b46b05).
Report is 3 commits behind head on develop-postgres.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           develop-postgres    #3545      +/-   ##
====================================================
+ Coverage             88.62%   88.75%   +0.12%     
====================================================
  Files                   341      341              
  Lines                  8626     8632       +6     
  Branches               1924     1927       +3     
====================================================
+ Hits                   7645     7661      +16     
+ Misses                  638      636       -2     
+ Partials                343      335       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vitest.config.ts Show resolved Hide resolved
vitest.config.ts Show resolved Hide resolved
coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 5, 2025
package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unused package

@JaiPannu-IITI
Copy link
Author

Ok sir

@palisadoes palisadoes merged commit 96f217a into PalisadoesFoundation:develop-postgres Feb 5, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants