Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package react-toastify from ^10.0.6 to ^11.0.3 #3543

Conversation

hkumar1729
Copy link

@hkumar1729 hkumar1729 commented Feb 4, 2025

What kind of change does this PR introduce?
Upgrades React-Toastify from ^10.0.6 to ^11.0.3.

Issue Number:
Fixes #3514

Summary of changes
Upgraded React-Toastify from 10.0.6 to 11.0.3.
Removed unnecessary CSS import since v11 now injects styles automatically.
Verified that toast notifications work as expected.
act from react-dom/test-utils is deprecated, use @testing-library/react instead

Does this PR introduce a breaking change?
No

Summary by CodeRabbit

  • Chores
    • Upgraded the toast notification library to version 11.0.3 for enhanced performance and features.
    • Removed default styling imports for toast notifications, which may affect their visual presentation.

Copy link
Contributor

coderabbitai bot commented Feb 4, 2025

Walkthrough

This pull request updates the react-toastify dependency from version ^10.0.6 to ^11.0.3 in package.json. It also removes the CSS import for react-toastify from both src/index.tsx and src/components/EventRegistrantsModal/AddOnSpotAttendee.tsx. Additionally, the test file OrgListCard.spec.tsx has its import statements consolidated by merging the separate import of act with other testing utilities. No functional changes or modifications to component logic have been introduced.

Changes

File(s) Change Summary
package.json Upgraded react-toastify from ^10.0.6 to ^11.0.3
src/components/EventRegistrantsModal/AddOnSpotAttendee.tsx
src/index.tsx
Removed CSS import for react-toastify (import 'react-toastify/dist/ReactToastify.css';)
src/components/OrgListCard/OrgListCard.spec.tsx Consolidated import statements by merging act with render and screen from @testing-library/react

Assessment against linked issues

Objective Addressed Explanation
Upgrade react-toastify from ^10.0.6 to ^11.0.3 [#3514]

Possibly related issues

Possibly related PRs

Suggested labels

ignore-sensitive-files-pr

Suggested reviewers

  • palisadoes

Poem

Hopping through the files with a joyful beat,
I upgraded my toast—oh, what a feat!
The CSS slipped away with a gentle “bye,”
And the imports now harmonize as they fly.
In the code garden, bugs scurry from sight,
A rabbit's delight in every byte,
Carrots and code make our future bright!

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd20eb1 and 0b12dc4.

📒 Files selected for processing (1)
  • src/components/OrgListCard/OrgListCard.spec.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/components/OrgListCard/OrgListCard.spec.tsx
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Test Application

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Feb 4, 2025

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 4, 2025
@hkumar1729 hkumar1729 changed the title Upgraded React-Toastify from 10.0.6 to 11.0.3 Upgrade React-Toastify from 10.0.6 to 11.0.3 Feb 4, 2025
@hkumar1729 hkumar1729 changed the title Upgrade React-Toastify from 10.0.6 to 11.0.3 Upgrade package react-toastify from ^10.0.6 to ^11.0.3 Feb 4, 2025
coderabbitai[bot]
coderabbitai bot previously approved these changes Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (00d3c15) to head (0b12dc4).
Report is 2 commits behind head on develop-postgres.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           develop-postgres    #3543      +/-   ##
====================================================
+ Coverage             88.62%   88.75%   +0.12%     
====================================================
  Files                   341      341              
  Lines                  8626     8632       +6     
  Branches               1924     1927       +3     
====================================================
+ Hits                   7645     7661      +16     
+ Misses                  638      636       -2     
+ Partials                343      335       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hkumar1729
Copy link
Author

@palisadoes sir please add sensitive file tag.

@palisadoes palisadoes merged commit b0d6fe1 into PalisadoesFoundation:develop-postgres Feb 5, 2025
18 of 19 checks passed
@hkumar1729 hkumar1729 deleted the chore/dependency-upgrade branch February 7, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants