Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Figma: Refactor CSS files in src/components/CollapsibleDropdown #3330" #3469

Merged

Conversation

palisadoes
Copy link
Contributor

@palisadoes palisadoes commented Jan 28, 2025

  1. Reverting Figma: Refactor CSS files in src/components/CollapsibleDropdown #3330 #3463
  2. Causing these errors on merging with the code base
    1. https://github.com/PalisadoesFoundation/talawa-admin/actions/runs/13003284750/job/36265756676

Summary by CodeRabbit

  • Style
    • Refactored styling for CollapsibleDropdown component
    • Moved CSS classes from global stylesheet to component-specific module
    • Updated class names and styling for dropdown icon and collapse button

@palisadoes palisadoes added the ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files label Jan 28, 2025
Copy link
Contributor

coderabbitai bot commented Jan 28, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request reorganizes the CSS styling for the CollapsibleDropdown component by moving specific CSS classes from the global app.module.css file to a dedicated CollapsibleDropdown.module.css module. Three new CSS classes are introduced: .iconWrapper, .collapseBtn, and .iconWrapperSm, while the corresponding classes in app.module.css are removed. The changes also include updates to the component's TypeScript file to reflect the new class names and import paths.

Changes

File Change Summary
src/components/CollapsibleDropdown/CollapsibleDropdown.module.css Added three new CSS classes: .iconWrapper, .collapseBtn, and .iconWrapperSm with specific styling properties
src/components/CollapsibleDropdown/CollapsibleDropdown.tsx Updated CSS import and class names to use the new module-specific styles
src/style/app.module.css Removed three CSS classes: .collapsibleDropdownIconWrapper, .collapsibleDropdownCollapseBtn, and .collapsibleDropdownIconWrapperSm

Possibly related PRs

Poem

🐰 A Rabbit's Ode to CSS Refactor
Styles once global, now find their home
In modules neat, no longer roam
Classes dance with newfound grace
A cleaner code, a tidy space!
Hop, hop, hooray for modular flair! 🎨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 01120c6 and 6899d79.

📒 Files selected for processing (3)
  • src/components/CollapsibleDropdown/CollapsibleDropdown.module.css (1 hunks)
  • src/components/CollapsibleDropdown/CollapsibleDropdown.tsx (3 hunks)
  • src/style/app.module.css (0 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Our Pull Request Approval Process

Thanks for contributing!

Testing Your Code

Remember, your PRs won't be reviewed until these criteria are met:

  1. We don't merge PRs with poor code quality.
    1. Follow coding best practices such that CodeRabbit.ai approves your PR.
  2. We don't merge PRs with failed tests.
    1. When tests fail, click on the Details link to learn more.
    2. Write sufficient tests for your changes (CodeCov Patch Test). Your testing level must be better than the target threshold of the repository
    3. Tests may fail if you edit sensitive files. Ask to add the ignore-sensitive-files-pr label if the edits are necessary.
  3. We cannot merge PRs with conflicting files. These must be fixed.

Our policies make our code better.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@palisadoes palisadoes merged commit 540dd4a into develop-postgres Jan 28, 2025
13 of 15 checks passed
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.65%. Comparing base (73cf8cd) to head (6899d79).
Report is 5 commits behind head on develop-postgres.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           develop-postgres    #3469       +/-   ##
=====================================================
+ Coverage              1.90%   88.65%   +86.75%     
=====================================================
  Files                   316      338       +22     
  Lines                  8249     8620      +371     
  Branches               1880     1918       +38     
=====================================================
+ Hits                    157     7642     +7485     
+ Misses                 8083      649     -7434     
- Partials                  9      329      +320     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-sensitive-files-pr The contributor has a legitimate reason for editiing protected files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant