-
-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for src/components/AddOn/core/AddOnEntry/AddOnEntry.tsx #1106
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1106 +/- ##
===========================================
+ Coverage 92.99% 93.45% +0.46%
===========================================
Files 137 138 +1
Lines 3283 3285 +2
Branches 913 913
===========================================
+ Hits 3053 3070 +17
+ Misses 221 208 -13
+ Partials 9 7 -2 ☔ View full report in Codecov by Sentry. |
await wait(100); | ||
const btn = getByTestId('AddOnEntry_btn_install'); | ||
expect(btn.innerHTML).toMatch(/install/i); | ||
debug(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is debug()
used here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the debug()
function to debug the test case using jest-preview but forgot to remove it, thank you for pointing this out. I'm removing it now.
Please open another PR for this against the same issue. This one is merged |
What kind of change does this PR introduce?
Code Coverage
Issue Number:
Fixes #1039
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Added tests to achieve 100% coverage for src/components/AddOn/core/AddOnEntry/AddOnEntry.tsx
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes