Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bradyclifford
Copy link

@bradyclifford bradyclifford commented Jun 14, 2023

Update node dependencies to latest.

It is odd that these are actually included in the repo. Perhaps in the future a build can be added to this repo so the dependencies themselves don't have to be added to the repo.

The updated action/core dependency includes critical updates.
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

If action/core is not updated to the version mentioned in the article above in the near future, this action will fail to function.

@bradyclifford
Copy link
Author

I have tested this change with a real PagerDuty account. Also tested it with the test routing key, see runner: https://github.com/bradyclifford/pagerduty-change-events-action/actions/runs/5272710041

     - name: Create a change event
        uses: bradyclifford/pagerduty-change-events-action@patch-1
        with:
          integration-key: 737ea619db564d41bd9824063e1f6b08
          custom-event: Test custom event with dependency updates

image

@bradyclifford
Copy link
Author

This might be a hard PR to review with all of the changes. All I did was run npm install locally and update all of the changes in node_modules.

If you don't trust this PR, I suggest the owner of this repo runs npm install themselves and merges those changes in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant