Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CINN][Warning Mitigation] Skip SetShapeOrDataForValue for null Value in InitLocalShapeAnalysis #70980

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[CINN][Warning Mitigation] Skip SetShapeOrDataForValue for null Value in InitLocalShapeAnalysis #70980

wants to merge 1 commit into from

Conversation

ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Jan 25, 2025 •
edited
Loading

PR Category

CINN

PR Types

Not User Facing

Description

缓解为 NULL Value 设置 ShapeOrData 的 Warning

Pcard-67164

  • Skip SetShapeOrDataForValue for null Value in InitLocalShapeAnalysis

TODO

  • 应该还有一种是 op 符号推导过程中，给输出的 NULL Value 设置了 ShapeOrData.
  • 需要确认 GetShapeOrDataForValue 里面有对 NULL Value 的处理，返回 NullShapeOrDataDimExpr，设置 NULL Value 的 ShapeOrData warning 是否必须

@ooooo-create ooooo-create mentioned this pull request Jan 25, 2025
Open
2 tasks
@ooooo-create ooooo-create force-pushed the skip_set_shape_for_null_value branch from c60d7b2 to fef969e Compare January 25, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ooooo-create