[CINN] Use trunc instead of fesetround to avoid affect other calculation precision in same process
#70766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulation precision in same process
|
你的PR提交成功，感谢你对开源项目的贡献! |
zyfncg
approved these changes
Jan 10, 2025
SigureMo
deleted the
cinn/use-trunc-instead-of-fesetround-to-avoid-affect-other-calculation-in-process
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Bug fixes
Description
std::fesetround1 会影响当前进程浮点舍入规则，后续计算精度都会受到影响（后续 Python、NumPy 浮点数表示都会有问题），包括 #70510 中的 guard 精度问题，因此尝试使用 trunc 解决 #64529 的上界溢出问题#70510 后续找时间 revert 下
PCard-66972
Footnotes
https://en.cppreference.com/w/cpp/numeric/fenv/feround ↩