[CINN]backend support stmt to expr visitor and run on func body #70739

Hongqing-work · 2025-01-09T06:42:59Z

PR Category

CINN

PR Types

Improvements

Description

pcard-67164
This PR Improves CINN backend IR in the following part:

add stmt to expr default visitor
allow expr inplace modify
allow func pass only run on func body

paddle-bot · 2025-01-09T06:43:04Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zyfncg · 2025-01-09T16:18:27Z

paddle/cinn/pass/pass.h

+class ExprPass : public Pass<ir::Expr*> {
 public:
  explicit ExprPass(const std::string& name) : Pass(PassKind::PK_STMT, name) {}
-  virtual LogicalResult Run(ir::Expr expr) = 0;
+  virtual LogicalResult Run(ir::Expr* expr) = 0;


Expr本身已经是一个指针类型了，为什么要换成Expr*类型？

[CINN]backend support stmt to expr visitor and run on func body

97c4c1e

zyfncg reviewed Jan 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CINN]backend support stmt to expr visitor and run on func body #70739

[CINN]backend support stmt to expr visitor and run on func body #70739

Hongqing-work commented Jan 9, 2025

paddle-bot bot commented Jan 9, 2025

zyfncg Jan 9, 2025

[CINN]backend support stmt to expr visitor and run on func body #70739

Are you sure you want to change the base?

[CINN]backend support stmt to expr visitor and run on func body #70739

Conversation

Hongqing-work commented Jan 9, 2025

PR Category

PR Types

Description

paddle-bot bot commented Jan 9, 2025

zyfncg Jan 9, 2025

Choose a reason for hiding this comment