Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clean old comm][fluid_ops]c_allreduce_op.h #70732

Merged
merged 2 commits into from
Jan 9, 2025
Merged

[clean old comm][fluid_ops]c_allreduce_op.h #70732

merged 2 commits into from
Jan 9, 2025

Conversation

co63oc
Copy link
Contributor

@co63oc co63oc commented Jan 9, 2025

PR Category

Communication Library

PR Types

Others

Description

c_allreduce_op.h 移除 FLAGS_dynamic_static_unified_comm

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Jan 9, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Jan 9, 2025
@co63oc co63oc changed the title CI测试不review[fluid_ops]c_allreduce_op.h [clean old comm][fluid_ops]c_allreduce_op.h Jan 9, 2025
liym27
liym27 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liym27 liym27 merged commit f70042a into PaddlePaddle:develop Jan 9, 2025
31 of 32 checks passed
@co63oc co63oc deleted the fix226 branch January 10, 2025 01:09
liym27 added a commit that referenced this pull request Jan 20, 2025
@liym27
Revert "[clean old comm][fluid_ops]c_allreduce_op.h (#70732)"
73e8a8c 
This reverts commit f70042a.
@liym27 liym27 mentioned this pull request Jan 20, 2025
Open
liym27 added a commit to liym27/Paddle that referenced this pull request Jan 21, 2025
@liym27
Revert "[clean old comm][fluid_ops]c_allreduce_op.h (PaddlePaddle#70732…
005ee14 
…)"

This reverts commit f70042a.
@liym27 liym27 mentioned this pull request Jan 22, 2025
Merged
liym27 added a commit that referenced this pull request Jan 22, 2025
@liym27
Revert "[clean old comm][fluid_ops] c_allreduce_op.h" (#70929)
feb941a 
* Revert "[clean old comm][fluid_ops] c_allreduce_op.h (#70789)"
This reverts commit 8924689.

* Revert "[clean old comm][fluid_ops]c_allreduce_op.h (#70732)"
This reverts commit f70042a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liym27 liym27 liym27 approved these changes

Assignees
No one assigned
Labels
contributor External developers PaddlePaddle Hackathon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@co63oc @liym27 @luotao1