[CINN][Backend Pass Update No.5] Update ir_simplify pass #70666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Comment on lines
49
to
50
| struct SimplifyNoPureMathMutator : public ir::IRMutator<ir::Expr*>, | ||
| public ir::stmt::StmtMutator<> { |
There was a problem hiding this comment.
这里不需要再改写了，用ExprPass即可，PassManager会遍历所有Statement内部的Expr进行改造
Comment on lines
144
to
145
| struct SimplifyLoadMutator : public ir::IRMutator<ir::Expr*>, | ||
| public ir::stmt::StmtMutator<> { |
Comment on lines
229
to
235
| struct SimplifyStoreMutator : public ir::IRMutator<ir::Expr*>, | ||
| public ir::stmt::StmtMutator<> { | ||
| void operator()(Expr* x) { ir::IRMutator<ir::Expr*>::Visit(x, x); } | ||
|
|
||
| void operator()(ir::stmt::BlockRef block) { | ||
| ir::stmt::StmtMutator<>::VisitBlock(block); | ||
| } |
There was a problem hiding this comment.
这里也不需要继承这两个Mutator，直接针对特定Statement改造就行
|
需要再确认一下使用何种Pass进行修改 |
Albresky
commented
Jan 8, 2025
| // TODO(Albresky): Is this pass necessary in stmt-based new IR? If so, | ||
| // we cannot obtain the father node of the current block, so how to | ||
| // reduce the nested unnecessary block? | ||
| struct SimplifyBlocksMutator : public ir::IRMutator<> { |
There was a problem hiding this comment.
@Hongqing-work Hi，我有个疑问。请问在改造后的新 IR 中，是否还存在这种两个 Block 嵌套的情况？如果有，父亲 Block 应该在当前 Block 的 scope 外，此时如何将当前 Block 的 stmt 合并到父亲呢？
Albresky
requested review from
SigureMo,
zhwesky2010,
wanghuancoder,
zrr1999,
gouzil,
sneaxiy,
raindrops2sea,
risemeup1,
zhangbo9674,
XieYunshen,
JiabinYang and
phlrain
as code owners
Albresky
force-pushed
the
cinn-pass-ir_simplify
branch
2 times, most recently
from
16b85ca to
0150a6f
Compare
Hongqing-work
removed request for
JiabinYang,
wanghuancoder,
XieYunshen and
sneaxiy
Hongqing-work
removed request for
raindrops2sea,
SigureMo,
phlrain,
zrr1999,
zhwesky2010,
risemeup1,
gouzil and
zhangbo9674
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Improvements
Description
改造了 IR Simplify Pass