[CodeStyle][Typos][A-[21-30]] Fix typos (allctor,almostly,alog,Aread,Allways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
#69482
Conversation
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
标题不合规范 or PR 描述不按模板来，一律不予 review cc @MrXnneHang |
|
好 |
rich04lin
changed the title
|
|
rich04lin
changed the title
There was a problem hiding this comment.
Copilot reviewed 3 out of 7 changed files in this pull request and generated no suggestions.
Files not reviewed (4)
- paddle/cinn/operator_fusion/graph_transformer/search_algorithm.h: Language not supported
- paddle/fluid/pybind/pybind.cc: Language not supported
- test/cpp/fluid/platform/errors_test.cc: Language not supported
- test/cpp/phi/kernels/test_gpu_timer.cu: Language not supported
[CodeStyle][Typos][A-[21,22,24]]你写成这样吧，我去改一下 FAQ 标题示例，我不太会写正则... |
rich04lin
changed the title
标题就写这？知道自己在干什么么？知道的话在标题里说明下 |
|
人家让你把前缀改成这个 |
rich04lin
changed the title
rich04lin
changed the title
| @@ -10,7 +10,7 @@ grad = "grad" | |||
| arange = "arange" | |||
| ot = 'ot' | |||
| pash = 'pash' | |||
|
|
|||
| anc = 'anc' | |||
| @@ -138,8 +138,8 @@ struct SearchAlgorithm<ReverseTopoNodePairPattern, | |||
| template <typename Kind, typename GraphMatcher, typename GraphOperation> | |||
| void GraphTransformer(PatternGraph* graph) { | |||
| VLOG(4) << "Start GraphTransformer..."; | |||
| auto alog = SearchAlgorithm<Kind, GraphMatcher, GraphOperation>(graph); | |||
| alog(); | |||
| auto along = SearchAlgorithm<Kind, GraphMatcher, GraphOperation>(graph); | |||
There was a problem hiding this comment.
| auto along = SearchAlgorithm<Kind, GraphMatcher, GraphOperation>(graph); | |
| auto algo = SearchAlgorithm<Kind, GraphMatcher, GraphOperation>(graph); |
自己看上下文，这不是 SearchAlgorithm 返回一个 Algorithm 吗？
| @@ -72,7 +72,7 @@ def _default_pruning( | |||
| # In sparse training, layer weight matrices is viewed sparse matrix A, so | |||
| # the math formula should be 'Act(WX + b)'. However, default formula in PaddlePaddle | |||
| # is 'Act(XW + b)'. For enabling SPMMA, weights and inputs should be transposed | |||
| # for computing, Act( (W^T X^T)^T + b). Therefore, we have to prune alog k dimension | |||
| # for computing, Act( (W^T X^T)^T + b). Therefore, we have to prune log k dimension | |||
There was a problem hiding this comment.
| # for computing, Act( (W^T X^T)^T + b). Therefore, we have to prune log k dimension | |
| # for computing, Act( (W^T X^T)^T + b). Therefore, we have to prune along k dimension |
从 71 行能看出来是 along
| @@ -354,7 +354,7 @@ def __init__( | |||
| self._quantized_weight_var_name = set() | |||
| self._quantized_act_var_name = set() | |||
| self._weight_op_pairs = {} | |||
| # The vars for alog = KL or hist | |||
| # The vars for along = KL or hist | |||
There was a problem hiding this comment.
| # The vars for along = KL or hist | |
| # The vars for algo = KL or hist |
算法 KL
| Functor along0 = Along<4, 256, 1024>; | ||
| Functor along1 = Along<1, 256, 1024>; | ||
| Functor along2 = Along<1, 256, 8>; |
There was a problem hiding this comment.
| Functor along0 = Along<4, 256, 1024>; | |
| Functor along1 = Along<1, 256, 1024>; | |
| Functor along2 = Along<1, 256, 8>; | |
| Functor algo0 = Algo<4, 256, 1024>; | |
| Functor algo1 = Algo<1, 256, 1024>; | |
| Functor algo2 = Algo<1, 256, 8>; |
算法算法算法，Along 是什么鬼？
test/dataset/imikolov_test.py
Outdated
| @@ -31,7 +31,7 @@ def test_train(self): | |||
| self.check_reader(paddle.dataset.imikolov.train(WORD_DICT, n), n) | |||
|
|
|||
| first_line = ( | |||
| 'aer banknote berlitz calloway centrust cluett fromstein ' | |||
| 'are banknote berlitz calloway centrust cluett fromstein ' | |||
There was a problem hiding this comment.
这里不能修改，因为这里本来就不是有效词汇，需要将本文件在配置中 ignore 掉
参考 crate-ci/typos#316 (comment)
配置参考 https://github.com/crate-ci/typos/blob/master/docs/reference.md#config-fields
可用 files.ignore-files 配置项
@MrXnneHang 可以在 Q&A 里提及，这种本身就是使用一些 typos 的字面量，整个文件可以 ignore
|
CI 挂了，与修改相关，自己看下 CI 报错 |
…llways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
…llways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
…llways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
_typos.toml
Outdated
| @@ -10,6 +10,8 @@ grad = "grad" | |||
| arange = "arange" | |||
| ot = 'ot' | |||
| pash = 'pash' | |||
| anc = 'anc' | |||
| algo = "algo" | |||
There was a problem hiding this comment.
人家有把 algo 识别成 typo 吗？没有加在这干什么？
…llways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
…llways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
.gitignore
Outdated
| @@ -112,3 +112,4 @@ paddle/phi/kernels/fusion/cutlass/conv2d/cutlass | |||
| paddle/phi/kernels/fusion/cutlass/gemm_epilogue/build | |||
| paddle/phi/kernels/fusion/cutlass/gemm_epilogue/cutlass | |||
| python/paddle/_typing/libs/**/*.pyi | |||
| *aer* | |||
There was a problem hiding this comment.
恢复
在 _typos.toml 里加
[files]
extend-exclude = [
"test/dataset/imikolov_test.py"
]放在最上面
|
@rich04lin |
…llways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
…llways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
…llways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
…llways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
…llways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
SigureMo
changed the title
allctor,almostly,alog,Aread,Allways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
SigureMo
changed the title
allctor,almostly,alog,Aread,Allways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)allctor,almostly,alog,Aread,Allways,alway,ane,adn,expaned,annotaions,annotaion,architecure,architecuture,aer)
|
下次1个PR可以少领几个，更容易快速合入 |
|
……不是说了不用动了吗？ |
对不起，我把其他单词修改提交到这里了，撤回了 |
|
仅这个任务，全部修改完需要改动 21 个文件，我之前都改完了，你全都覆盖掉了 |
啊对不起，那还能撤回修改吗 |
不能，因为你 force push 了 自己改回来吧，我不管了 |
老师可以重新开一个issue吗，我重新写 |
|
你再新建一个分支然后重新做最后push上来再PR即可。 |
|
PR Category
User Experience
PR Types
Devs
Description
Fix:
Undo: