ekf2: delete obsolete _bad_vert_accel_detected #18835
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete unused
_bad_vert_accel_detected
and update fusion helper methods._bad_vert_accel_detected
was replaced with_fault_status.flags.bad_acc_vertical
here EKF: add fault status bit for clipping PX4-ECL#917 (PX4/PX4-ECL@6e99ebd)_bad_vert_accel_detected
, but in an incomplete stateWe really need to be more careful when dealing with old PRs that are dragged along and rebased many times. I've personally found it can be easy to lose sight of real incremental history when rebasing multiple commits. In a lot of cases I think we're safer to merge master into these long lived branches, then finally squash & merge once done.