Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ekf2: delete obsolete _bad_vert_accel_detected #18835

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

dagar
Copy link
Member

@dagar dagar commented Dec 10, 2021

Delete unused _bad_vert_accel_detected and update fusion helper methods.

We really need to be more careful when dealing with old PRs that are dragged along and rebased many times. I've personally found it can be easy to lose sight of real incremental history when rebasing multiple commits. In a lot of cases I think we're safer to merge master into these long lived branches, then finally squash & merge once done.

Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good finding, thanks!
We should add a unit test to test this at some point

@dagar dagar merged commit fc17797 into master Dec 13, 2021
@dagar dagar deleted the pr-ekf2_bad_vert_accel_detected branch December 13, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants