Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial control allocation support (safe to merge) #16528

Merged
merged 15 commits into from
Jan 18, 2021

Conversation

dagar
Copy link
Member

@dagar dagar commented Jan 10, 2021

Continued #13351 that should be safe for merging to support continued development.

Apologies for the squashed history, the rebase of #13351 got a little hairy and this was ultimately safer.

LorenzMeier
LorenzMeier previously approved these changes Jan 10, 2021
Copy link
Member

@LorenzMeier LorenzMeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to bring it in like that to keep things moving.

@LorenzMeier
Copy link
Member

@dagar SITL tests and param metadata tests are failing.

@LorenzMeier
Copy link
Member

Invalid unit in AVC_X_FF: N.m.s/rad

@xdwgood
Copy link
Contributor

xdwgood commented Jan 11, 2021

Will the corresponding document description be synchronized?

@dagar
Copy link
Member Author

dagar commented Jan 11, 2021

Will the corresponding document description be synchronized?

I'm not sure what you're referring to, could you be more specific?

@xdwgood
Copy link
Contributor

xdwgood commented Jan 11, 2021

For example, how to use this new control allocation on a homemade drone?

@dagar dagar force-pushed the pr-control_allocation_merge branch 2 times, most recently from 8963233 to 8d06f1e Compare January 11, 2021 03:09
@dagar
Copy link
Member Author

dagar commented Jan 11, 2021

For example, how to use this new control allocation on a homemade drone?

We'll get there, but it's a bit early. At this stage I'm trying to bring in this incremental progress to enable further development.

@dagar dagar force-pushed the pr-control_allocation_merge branch from 8d06f1e to 5120d77 Compare January 11, 2021 03:55
@@ -323,6 +323,9 @@ void Standard::update_transition_state()
}
}


_v_att_sp->thrust_body[0] = _pusher_throttle;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

@dagar dagar force-pushed the pr-control_allocation_merge branch from 5120d77 to 20b5189 Compare January 11, 2021 05:04
@dagar
Copy link
Member Author

dagar commented Jan 11, 2021

The standard VTOL failures look real.

@dagar dagar marked this pull request as draft January 11, 2021 14:54
@jlecoeur jlecoeur self-assigned this Jan 11, 2021
bresch
bresch previously approved these changes Jan 12, 2021
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through quite carefully and did not stop anything strange.

@dagar dagar force-pushed the pr-control_allocation_merge branch from 20b5189 to b9ce5c4 Compare January 18, 2021 01:29
@dagar dagar marked this pull request as ready for review January 18, 2021 01:29
@dagar
Copy link
Member Author

dagar commented Jan 18, 2021

The build failure was caused by some leftovers in the SITL vtol_standard aiframe.

@dagar dagar force-pushed the pr-control_allocation_merge branch from b9ce5c4 to 08c559e Compare January 18, 2021 14:24
jlecoeur and others added 5 commits January 18, 2021 10:55
 - control allocation module with multirotor, VTOL standard, and tiltrotor support
 - angular_velocity_controller
 - See #13351 for details

Co-authored-by: Silvan Fuhrer <[email protected]>
Co-authored-by: Roman Bapst <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants