Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Benificiary visit-api modified for all visit category #78

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Multiple Benificiary visit-api modified for all visit category #78

merged 5 commits into from
Nov 27, 2023

Conversation

indraniBan
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix
  • New feature
  • Enhancement
  • Refactoring
  • Documentation
  • Other ( please specify )

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@devikasuresh20 devikasuresh20 self-requested a review November 10, 2023 10:52
Copy link
Member

@drtechie drtechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indraniBan

Here any error that happens during booking is interpreted as the slot is already booked.
How are "Error while booking slot." and "Slot already booked" in the same context?

Secondly, using error message comparison is not a good idea.
It's best to raise a specific exception for an already booked slot and catch the same.

cc: @devikasuresh20

Also, please complete the PR template.

@drtechie
Copy link
Member

Also not sure what the 5000 error code is.
Is this an HTTP status code? I think you meant 500.

@drtechie
Copy link
Member

The code that prepares jsnOBJ is repeated in try-and-catch blocks. There is potential to make it DRY.

ravishanigarapu
ravishanigarapu approved these changes Nov 15, 2023
Copy link
Member

@ravishanigarapu ravishanigarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

Copy link
Member

@ravishanigarapu ravishanigarapu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

@ravishanigarapu ravishanigarapu enabled auto-merge (rebase) November 20, 2023 13:49
Copy link
Member

@helenKaryamsetty helenKaryamsetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked by ravi

@ravishanigarapu ravishanigarapu enabled auto-merge (squash) November 27, 2023 12:11
@ravishanigarapu ravishanigarapu merged commit 8cc8d79 into PSMRI:develop Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants