Skip to content

Commit

Permalink
Merge pull request #10 from guivaloz:guivaloz/mejorar-get-persona-wit…
Browse files Browse the repository at this point in the history
…h-curp

Se mejoro get_persona_with_curp
  • Loading branch information
guivaloz authored Mar 8, 2024
2 parents 62f0e9b + 09260ed commit 32e2981
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions perseo/v4/personas/crud.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""
Personas v4, CRUD (create, read, update, and delete)
"""

from typing import Any

from sqlalchemy.orm import Session
Expand Down Expand Up @@ -78,14 +79,12 @@ def get_persona_with_rfc(database: Session, persona_rfc: str) -> Persona:


def get_persona_with_curp(database: Session, persona_curp: str) -> Persona:
"""Consultar una persona por su CURP"""
"""Consultar una persona por su CURP (porque el CURP no es único, se obtiene la primera coincidencia con estatus A)"""
try:
curp = safe_curp(persona_curp)
except ValueError as error:
raise MyNotValidParamError(str(error)) from error
persona = database.query(Persona).filter_by(curp=curp).first()
persona = database.query(Persona).filter_by(curp=curp).filter_by(estatus="A").first()
if persona is None:
raise MyNotExistsError("No existe ese persona")
if persona.estatus != "A":
raise MyIsDeletedError("No es activa ese persona, está eliminada")
return persona

0 comments on commit 32e2981

Please sign in to comment.