Document untrigger-filter #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pablete1234
reviewed
Aug 17, 2024
| @@ -39,6 +39,7 @@ In the future, some features that are currently used in Kits may be transferred | |||
| | `id` | Unique identifier used to reference this action from other places in the XML. | <span className="badge badge--primary">String</span> | | |||
| | `scope` | Sets the scope target an action should operate against. | `player`, `team`, or `match` | | |||
| | `filter` | A filter that is tested before running actions inside. | [Filter](/docs/modules/mechanics/filters) | | |||
| | `untrigger-filter` | Filters if an untrigger event (e.g. a trigger filter stops matching) should be passed down to children, similar to [kit lending](/docs/modules/gear/kits#dynamic-kits). | [Filter](/docs/modules/mechanics/filters) | `never` | | |||
There was a problem hiding this comment.
I think this description makes it sound like a totally alien thing. Maybe streamline it with the above filter, so while filter is:
A filter that is tested before running actions inside
this should be:
A filter that is tested before deactivating the actions inside
then follow-up with the note about actions untriggering being a mechanic parallel to that of removable kits & kit lending. Also can mention that most actions don't have explicit untrigger logic and so they do nothing on untrigger
There was a problem hiding this comment.
I've implemented your suggestion in the latest commit, let me know if it's good
TheRealPear
force-pushed
the
action-untrigger-20240816
branch
from
73ca5e4 to
dc95fc1
Compare
TheRealPear
force-pushed
the
action-untrigger-20240816
branch
from
dc95fc1 to
147f8e6
Compare
TheRealPear
force-pushed
the
action-untrigger-20240816
branch
from
147f8e6 to
5e342f5
Compare
TheRealPear
force-pushed
the
action-untrigger-20240816
branch
from
5e342f5 to
7fd8c33
Compare
TheRealPear
force-pushed
the
action-untrigger-20240816
branch
from
7fd8c33 to
192e88e
Compare
Signed-off-by: Pear <[email protected]>
TheRealPear
force-pushed
the
action-untrigger-20240816
branch
from
192e88e to
6c5e79b
Compare
Signed-off-by: Pear <[email protected]>
TheRealPear
force-pushed
the
action-untrigger-20240816
branch
from
94d9f6b to
e5b8c4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #135