Fix issues with spleef tracker #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spleef tracker is iterating to get all potential blocks under a player, however only actually ever checks for the block the player is in. This fixes up that bug to actually search different blocks under the player, as well as making the tracker a bit more lenient by increasing max time for spleef from 1 second to 1.5s, and radius for players from exactly their hitbox size to 0.05 more.
On top of those changes, it also changes from Block to Vector, to avoid keeping references to the world and needing to get blocks off of the world when none of the functionality requires it.