feat: TNT minecart tracking #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTtie
force-pushed
the
feat/track-tnt-minecarts
branch
3 times, most recently
from
9d64533 to
246da6f
Compare
Pugzy
reviewed
Feb 14, 2024
util/src/main/java/tc/oc/pgm/util/listener/TNTMinecartPlacementListener.java
Outdated
Show resolved
Hide resolved
Pablete1234
previously approved these changes
Feb 15, 2024
TTtie
force-pushed
the
feat/track-tnt-minecarts
branch
from
8f0a726 to
f83a191
Compare
Pablete1234
approved these changes
Feb 24, 2024
This commit introduces TNT minecart tracking into PGM, spawned into the world using dispensers or players (tracking player-placed TNT minecarts requires a patched version of SportPaper). This change also allows destroyables (cores and monuments) to be destroyed using TNT minecarts. Fixes PGMDev#1176. Signed-off-by: TTtie <[email protected]>
This prevents the possibility of team griefing using explosions (of any entity that can explode) on platforms where entity spawn tracking isn't supported (tested on Spigot). Signed-off-by: TTtie <[email protected]>
…reateEvent cascade Signed-off-by: TTtie <[email protected]>
Signed-off-by: TTtie <[email protected]>
Signed-off-by: TTtie <[email protected]>
This change should make it easier to think about edge cases when trying to correlate the event. Also, it's been refactored to emit a PlayerSpawnEntityEvent if further usage is needed in the future. Signed-off-by: TTtie <[email protected]>
Signed-off-by: TTtie <[email protected]>
Signed-off-by: TTtie <[email protected]>
TTtie
force-pushed
the
feat/track-tnt-minecarts
branch
from
a715a2d to
fcf0359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces TNT minecart tracking into PGM, spawned into the world by dispensers or players. This change also allows destroyables (cores and monuments) to be destroyed using TNT minecarts. In case the owner of TNT minecarts isn't known (e.g. while dispensing minecarts on Spigot), the behavior is unchanged.
I verified that this patch doesn't allow players to grief their own team's objective:
Demonstration videos
2024-01-17.18-27-11.576p.crf28.mp4
2024-01-17.18-29-13.720p.crf28.mp4
Fixes #1176.
Requires: Electroid/SportPaper#140