Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug that caused setting the picker to manual reset user settings #1291

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Zuiuzz
Copy link
Contributor

@Zuiuzz Zuiuzz commented Jan 5, 2024

The value associated with the manual setting for picker caused the left shift of the 1 (integer) to overflow. Using a 1 of type long prevents this overflow.
This overflow probably caused the settings to be incorrectly saved or loaded to the database thereby causing a reset of the user settings after a server restart.

@Zuiuzz Zuiuzz requested a review from Electroid as a code owner January 5, 2024 20:02
@Pablete1234 Pablete1234 added the ready PR is ready to merge label Feb 24, 2024
@Pablete1234 Pablete1234 added the bug Something isn't working label Feb 24, 2024
@Electroid Electroid merged commit 208dd02 into PGMDev:dev Feb 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PR is ready to merge
Development

Successfully merging this pull request may close these issues.

3 participants