Fix nicked player sorting in player list #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Be aware, this will put tbem always at the end, since everyone has the default group |
Pablete1234
reviewed
Jan 4, 2024
Pablete1234
reviewed
Jan 4, 2024
Comment on lines
74
to
75
| boolean aPerm = a.hasPermission(permission); | ||
| boolean bPerm = b.hasPermission(permission); |
There was a problem hiding this comment.
Suggested change
| boolean aPerm = a.hasPermission(permission); | |
| boolean bPerm = b.hasPermission(permission); | |
| boolean aPerm = a.hasPermission(permission) && aNick == null; | |
| boolean bPerm = b.hasPermission(permission) && bNick == null; |
If just included here, makes the follow-up if simpler
Signed-off-by: zzuf <[email protected]>
Pablete1234
approved these changes
Jan 4, 2024
Electroid
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a player with a rank is disguised, they keep their "real" position on the player list (appearing higher on the list than unranked players), making it extremely easy to differentiate nicked players from regular players as they're not following alphabetical order.
This PR adds some extra checks to the "group permission check" stage and after in PlayerOrder.
I have tested this in a local server with 4 clients.