Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sign logging rules #83

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Update sign logging rules #83

merged 1 commit into from
Jan 5, 2025

Conversation

Pablete1234
Copy link
Member

Updates sign logging to achieve a couple goals:

  • Symbol spam should not fill the chat too much (currently all chars are logged)
  • Single symbols should be logged (currently skipped due to <4 chars)

It does so by compacting lines with no text (ie: all special characters) removing consecutive duplicate chars. Additionally it implements a full message that roughly replicates the original sign, and can be seen on hover:
The sign placed:
image

The simplified chat view:
image

The full hover view:
image

Signed-off-by: Pablo Herrera <[email protected]>
Copy link
Member

@applenick applenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I like the new hover message. Great work 👍

@applenick applenick merged commit 3f0399d into dev Jan 5, 2025
2 checks passed
@applenick applenick deleted the compact-signs branch January 5, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants