GS-hw: Don't wrap on 16bit destination format for blend mix. #5540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps Dog's Life blending, we shouldn't wrap as we do more blend math afterward which will be wrong if we wrapped before.
|
We should note this is also wrong as that means the result of the blend is stored as 32bit and not 16bit. We might be lucky and it doesn't really matter (as it seems to not for Dog's Life), but we should be aware that later we might have to say no hardware blend on 16bit target in order to get the correctly truncated colour values. |
refractionpcsx2
approved these changes
Feb 18, 2022
lightningterror
added a commit
that referenced
this pull request
Feb 18, 2022
Allow to wrap on colclip. For real tho, ideal solution is sw blend, doing any clamp/wrap is wrong on blend mix.
lightningterror
added a commit
that referenced
this pull request
Feb 18, 2022
Allow to wrap on colclip. For real tho, ideal solution is sw blend, doing any clamp/wrap is wrong on blend mix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
GS-hw: Rename alpha_clamp to blend_mix.
GS-hw: Don't wrap on 16bit destination format for blend mix.
Helps Dog's Life blending, we shouldn't wrap as we do more blend math afterward which will be wrong if we wrapped before.
Rationale behind Changes
Solves blending issues on Dog's life.
Fixes #1004
Suggested Testing Steps
Test blending levels