-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clang-format checks in Danger #3
Open
robertodr
wants to merge
9
commits into
PCMSolver:master
Choose a base branch
from
robertodr:clang-format
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Style CheckCode style violations detected in the following files:
Execute one of the following actions and commit again:
hello_world.cpp--- hello_world.cpp
+++ hello_world.cpp
@@ -4,13 +4,11 @@
std::vector<int> myVector();
-std::string message() {
- return "Hello, Danger world!";
-}
+std::string message() { return "Hello, Danger world!"; }
int main() {
std::cout << message() << std::endl;
- std::vector< int > v = myVector();
- return EXIT_SUCCESS;
+ std::vector<int> v = myVector();
+ return EXIT_SUCCESS;
}
vector.cpp--- vector.cpp
+++ vector.cpp
@@ -1,13 +1,13 @@
#include <vector>
std::vector<int> myVector() {
-int arr[] = {16, 2, 77, 29};
-// Create a vector containing integers
-std::vector<int> v (arr, arr + sizeof(arr) /sizeof(arr[0]) );
+ int arr[] = {16, 2, 77, 29};
+ // Create a vector containing integers
+ std::vector<int> v(arr, arr + sizeof(arr) / sizeof(arr[0]));
-// Add two more integers to vector
-v.push_back(25);
-v.push_back(13);
+ // Add two more integers to vector
+ v.push_back(25);
+ v.push_back(13);
-return v;
+ return v;
}
Generated by 🚫 Danger |
robertodr
force-pushed
the
clang-format
branch
from
August 10, 2017 07:08
fd406ca
to
d31022e
Compare
4 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.