Support NiFi 2.x #19
Merged
Support NiFi 2.x #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest versions of NiFi change/remove API functions that are used by the Daffodil processors. Trying to use the current version of these processors in newer versions of Daffodil leads to NoClassDefFoundErrors and breaks NiFi. To fix this, this replaces those API functions/classes with variants that exist in both older and newer versions of NiFi. This allows this processor to maintain compatibility with older versions of NiFi while still working with newer versions. Specific changes include: - NiFi 2.x removes support for EventDriven processors. This is likely rarely used in NiFi 1.x flows so support for EventDriven is removed for DaffodilParse/Unparse processors - NiFi 2.x replaces the allowableValues(AllowableValues...) function with allowableValues(DescribedValue...). The DescribedValue variant does not exist in older versions of NiFi, so we instead just use the allowableValues(String...) variant, which exists in all versions of NiFi. This loses the human readable description of the field, but the allowable values are mostly self-descriptive. And in case there is still confusion, descriptions of the possible values are added to additionalDetails.html Closes OwlCyberDefense#18
mbeckerle
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
+1 Changes look fine. I am not a NiFi expert so I really cannot spot whether there are key details missing.
It's shame NiFi doesn't use Scala. I believe this AllowableValues thing could be done elegantly in Scala in a way that would be as simple in the code as just using strings, but which would be type safe at compile time and avoid the need for runtime checking code.
Definitely. Unfortunately, the NiFi property API is pretty much all string based, with a few helper functions to convert to primitives. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest versions of NiFi change/remove API functions that are used by the Daffodil processors. Trying to use the current version of these processors in newer versions of Daffodil leads to NoClassDefFoundErrors and breaks NiFi.
To fix this, this replaces those API functions/classes with variants that exist in both older and newer versions of NiFi. This allows this processor to maintain compatibility with older versions of NiFi while still working with newer versions.
Specific changes include:
Closes #18