Native playlist downloading and improved comments #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Almost finished, will merge after some more tests in a couple hours |
|
Everythings good, will merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the native playlist downloading has actually been fixed from my testing. Added some more docs in the code to say that the video-only route may also route playlists. Also generalized Channel to just being Archive everywhere in the code and also talked about it inside of the README.
In addition to these changes to make sure playlists are fully supported, comments have also been improved with
multiprocesspools for comment icon downloading and they've been gated behind--commentsbecause of extra time it takes. For massive videos they can have 100k+ comments so it's best to disable them but leave it as an easily-accessible option if you do want to archive them for small-medium channels.