add bucket options #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmcjury
commented
Apr 9, 2020
| @@ -56,12 +72,22 @@ def _monitor(self): # pragma: no cover | |||
| recv = self._app.events.Receiver( | |||
| conn, handlers={"*": self._process_event} | |||
| ) | |||
| setup_metrics(self._app, self._namespace) | |||
| setup_metrics( | |||
There was a problem hiding this comment.
Why does setup_metrics need to be called again? Same below. It was already called in core.py::start
pmcjury
commented
Apr 9, 2020
| """ | ||
| This initializes the available metrics with default values so that | ||
| even before the first event is received, data can be exposed. | ||
| """ | ||
| global TASKS |
There was a problem hiding this comment.
I would refactor this into a class or object to extend initialization ,instead of doing it here, but I wanted to limit changes, as it's my first PR for this project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding bucket options for histograms. The code is not ideal ( Globals ), but I did not want to refactor it. After some discussions, maybe we could find a better path.