Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookiecutter version #507

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Update cookiecutter version #507

merged 4 commits into from
Jan 16, 2025

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Jan 15, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Updated to the latest cookiecutter template version.
  • Addressed a few issues with existing workflows (security).

Does this PR introduce a breaking change?

Somewhat:

  • New vulture pre-commit hook is now enabled. Warnings will now be emitted for dead code blocks.

Other information:

mypy will take some effort to adopt. Several underlying libraries need to be ignored in the configuration. Plenty of work is needed in xclim before this can be fully consistent for both libraries.

@Zeitsperre Zeitsperre requested a review from RondeauG January 15, 2025 21:56
@Zeitsperre Zeitsperre self-assigned this Jan 15, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@Zeitsperre Zeitsperre merged commit c16c9c9 into main Jan 16, 2025
17 checks passed
@Zeitsperre Zeitsperre deleted the cookiecutter-update branch January 16, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants