Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not report coverage for initial builds #1555

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Do not report coverage for initial builds #1555

merged 1 commit into from
Dec 12, 2023

Conversation

Zeitsperre
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Prevents coverage from failing in initial Pull Request builds

Does this PR introduce a breaking change?

No.

Other information:

@Zeitsperre Zeitsperre added the standards / conventions Suggestions on ways forward label Dec 11, 2023
@Zeitsperre Zeitsperre requested a review from aulemahal December 11, 2023 16:05
@Zeitsperre Zeitsperre self-assigned this Dec 11, 2023
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Dec 11, 2023
@github-actions GitHub Actions
Copy link

Note
It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2023.9.12).

No further action is required.

@github-actions github-actions bot added the approved Approved for additional tests label Dec 11, 2023
@coveralls
Copy link

Coverage Status

coverage: 90.468% (+0.02%) from 90.447%
when pulling 1498aff on fix-coverage
into b905e55 on master.

@Zeitsperre Zeitsperre merged commit fdde515 into master Dec 12, 2023
23 checks passed
@Zeitsperre Zeitsperre deleted the fix-coverage branch December 12, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests CI Automation and Contiunous Integration standards / conventions Suggestions on ways forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeitsperre @coveralls @aulemahal