Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail on pip check #1550

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Do not fail on pip check #1550

merged 1 commit into from
Dec 6, 2023

Conversation

Zeitsperre
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Prevents upstream testing from failing on pip check
  • Don't run xclim like a Python module

Does this PR introduce a breaking change?

No.

Other information:

@Zeitsperre Zeitsperre requested a review from aulemahal December 6, 2023 16:09
@Zeitsperre Zeitsperre self-assigned this Dec 6, 2023
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Dec 6, 2023
@coveralls
Copy link

coveralls commented Dec 6, 2023 •
edited
Loading

Coverage Status

coverage: 90.447%. remained the same
when pulling 8e5752c on Zeitsperre-patch-1
into 6f75016 on master.

aulemahal
aulemahal approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions github-actions bot added the approved Approved for additional tests label Dec 6, 2023
@Zeitsperre Zeitsperre merged commit b905e55 into master Dec 6, 2023
22 checks passed
@Zeitsperre Zeitsperre deleted the Zeitsperre-patch-1 branch December 6, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests CI Automation and Contiunous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeitsperre @coveralls @aulemahal