Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pagination: make previous and next buttons accessible #2102
base: main
Are you sure you want to change the base?
Fix pagination: make previous and next buttons accessible #2102
Changes from 27 commits
9460019
4699306
55de330
bfb234f
f6d4185
9217af7
23bd2e7
02ef7e5
48886f6
48a954a
bfc5da4
812cf89
aa2f7fa
1aaa90a
69b1bef
9a352c8
04c86fd
4d151ad
9d8ad6c
6f753db
7992576
fb02b56
0a5b410
ba98b65
026d259
d57ee5e
15f3d6b
346f5ab
95c9c68
1a00d11
f7093fb
54523a8
eec7fb1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two should be named almost the same since their goal is the same. Maybe something like
$pagination-icon-efficient-width/height
? It add some changes to variables but it feel more handy to me. What would think about a change like this ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like
$pagination-icon-hitbox-width/height
? Or$pagination-icon-box-width/height
maybe?Not sure which one sounds more like a Bootstrap's name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any idea on how to call those. Let's wait for the last review to decide ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will be a job for the lead dev review 😉
Simple reminder: changing the name of
$pagination-icon-size
will need to be properly documented in our migration guide since it's an already existing variable.