Kr/final wip demo sandbox #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocktavious
commented
Dec 23, 2024
|
|
||
| on: | ||
| repository_dispatch: | ||
| types: | ||
| - actions | ||
| - sandbox |
There was a problem hiding this comment.
i will update the opslevel action after i merge this
rocktavious
commented
Dec 23, 2024
modules/demo_account/hierarchy.tf
Outdated
| @@ -11,16 +11,16 @@ module "product" { | |||
| description = "The system that manages the order workflow." | |||
| owner = module.product-engineering-team.this.id | |||
| services = [ | |||
| module.order-workflow.this.id, | |||
| module.order-fulfillment.this.id | |||
| # module.order-workflow.this.id, | |||
There was a problem hiding this comment.
TODO: need to fix this
rocktavious
commented
Dec 23, 2024
Comment on lines
+9
to
+12
| # Linux date command | ||
| # Replace `-v` flag and format the input for Linux `date` | ||
| adjusted=$(echo $3 | sed 's/-v //g' | sed 's/H/hour/g; s/d/day/g') | ||
| formatted_date=$(date -u -d "$adjusted" '+%FT%TZ') |
There was a problem hiding this comment.
i'm going out on a limb with chatGPT here
There was a problem hiding this comment.
On Ubuntu the output is something like
2024-12-23T19:42:16Z when $3 is "-v -1H"
rocktavious
commented
Dec 23, 2024
modules/demo_account/services.tf
Outdated
Comment on lines
12
to
13
| depends_on = [module.teams_from_csv] | ||
| for_each = { for svc in local.csv_services : svc.service_name => svc } |
There was a problem hiding this comment.
Suggested change
| depends_on = [module.teams_from_csv] | |
| for_each = { for svc in local.csv_services : svc.service_name => svc } | |
| for_each = { for svc in local.csv_services : svc.service_name => svc } |
I'm pretty sure this isn't needed because its used in owner field so terraform can figure it out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Problem
Solution
Checklist