check_package_version added, base variables for checks #13
Conversation
modules/check/base_variables.tf
Outdated
| @@ -0,0 +1,44 @@ | |||
| variable "category" { | |||
| type = string | |||
| description = "The id of the category the check belongs to." | |||
There was a problem hiding this comment.
So one thing we are losing here is the ability to use the categoryName since they don't have aliases. The stuff I was doing in modules/check/rubric.tf allowed you to do
module "check" {
source = "./modules/check"
category = "Security"
level = "Bronze"
}
With the way it is now you have to do ( reference an existing datasource )
module "check" {
source = "./modules/check"
category = "Z2lkOi8v098sdf093sdf0dsf0987sdf90w"
level = "Z2lkOi8vwerlkj987sdflkjwer9887sdf90wer"
}
Which is sub par and more verbose. We can move forward with this but thats the reason i had the locals with logic in modules/check/rubric.tf
There was a problem hiding this comment.
ohhh yes I see now. I'll bring back rubric.tf and make it work
| @@ -0,0 +1,8 @@ | |||
| data "opslevel_rubric_levels" "all" {} | |||
|
|
|||
| data "opslevel_rubric_level" "greatest_level_by_index" { | |||
There was a problem hiding this comment.
I see it now over in OpsLevel/terraform-provider-opslevel#481
Does the test HCL files allow for us to put stuff like this in there? or is this used by more then just 1 test?
There was a problem hiding this comment.
It's used for testing downstream. But it should be removed here and pushed over into the test logic there
No description provided.