refactor(step-generation, protocol-designer): create HydratedFormData #17308
+728
−947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Was cleaning up
StepArgs
a bit so it matches the command params a bit better and then ended up creatingHydratedFormData
type and wired it up. This resulted in a bit of a refactor and changing some arg names: i.e ->module
is nowmoduleId
for all instances andtemperature
is notcelsius
. This is so it matchesTemperatureParams
andModuleOnlyParams
which are used a lot for module commands.I also deleted a bunch of stuff in
generateSubsteps
because we no longer have substeps for every step type now. only thermocycler and mix and move liquid have substepsTest Plan and Hands on Testing
Smoke test creating protocols in PD, in particular make sure:
Changelog
HydratedFormData
and wire it indescription
andname
and create the form data for the thermocycler which was previously never created for some reason. changemodule
tomoduleId
,temperature
tocelsius
, and a few other things I think were changed that were more one-offsReview requests
lmk if anything seems weird to you!
Risk assessment
medium - this touches a bunch of code, if all tests pass (most importantly the migration files) then I am confident that these changes don't break anything.